Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irritating reaction emoticon panel #10720

Closed
Biep opened this issue Sep 2, 2019 · 13 comments
Closed

Irritating reaction emoticon panel #10720

Biep opened this issue Sep 2, 2019 · 13 comments

Comments

@Biep
Copy link

Biep commented Sep 2, 2019

When the mouse pointer only hovers over the reaction button, the panel with emoticons pops up - for no reason, because in order to select an emoticon one still needs first to click the button. And sometimes that panel is 'left behind' - it stays visible after the mouse has moved on.
Please let the panel only pop up after clicking the button, and disappear again after clicking it again.

@thosgood
Copy link

thosgood commented Sep 2, 2019

I'm guessing this was probably implicit in your suggestion, but the panel should also close if the user clicks anywhere outside of it too :-)

@turt2live
Copy link
Member

It would be good to have gifs of what sorts of conditions don't cause it to go away. There's an area around the tooltip to prevent it accidentally dismissing (because that's much more annoying), but there are potentially some bugs with how that works. Please include browser and operating system information alongside the gifs.

@Biep
Copy link
Author

Biep commented Sep 2, 2019

@thosgood: yes, I guess so. But (personal preference) clicking on one of the emoticons should not close it, as I might want to add another emoticon.
@turt2live: I'll try to get some. And I hope calling up the screen shot program won't make it close, otherwise I'll have to edit a full screen print.

@Biep
Copy link
Author

Biep commented Sep 2, 2019

@turt2live: not what you asked, but this leads to the emoticon panel hopping up and down between having the heart and the thumbsdown selected. I can only get the effect with those two emoticons - the other three pairs seem stable. It is consistently reproducible.
afbeelding
Ubuntu 19.04
The mouse pointer is black, and between the thumbsdown and the heart - as you no doubt expected already.

@Biep
Copy link
Author

Biep commented Sep 4, 2019

@turt2live: This should be what you asked.
afbeelding
The panel is very persistent: I hit the meta key to start the screenprint program, and the panel was still there when I took the pic. It survives Alt-Tab and back, and even switching to other rooms: it remains visible in those other rooms. It survives hide Riot + show Riot. In fact, I had to exit Riot and restart to get rid of it.

@turt2live
Copy link
Member

@Biep that's the kind of thing that would be good to report in a new, dedicated, issue.

@Biep
Copy link
Author

Biep commented Sep 4, 2019

You mean the first screenshot - the vibrating panel? I just did: #10751

@turt2live
Copy link
Member

turt2live commented Sep 4, 2019

No, I meant the stuck tooltip bug.

Edit: although I guess both is fine.

@Biep
Copy link
Author

Biep commented Sep 4, 2019

That second one I posted in reaction to your first comment here. But yes, there are three issues mixed up here:

  • The panel popping up on hovering, instead of waiting for a click.
  • The panel getting stuck and staying visible
  • The panel vibrating.

@turt2live
Copy link
Member

right... which had the underlying implication of opening new issues for unique things. I'm not trying to discredit the panel as annoying, but triaging each annoyance on its own is a better option for us to try and fix the problems.

I've opened #10752 to track the issue. I see that you've opened #10751 already for the vibrating problem.

If you run into other cases where the tooltip gets tuck, please open a new issue. For now though, I'm closing this in favour of the two issues mentioned above.

@Biep
Copy link
Author

Biep commented Sep 4, 2019

But shouldn't this one stay open for the original issue: the panel popping up on hovering? Or is there an issue for that one already too?

@turt2live
Copy link
Member

At this point I'd recommend a whole new issue so the slate can be cleaned.

@Biep
Copy link
Author

Biep commented Sep 4, 2019

OK. Done. #10753.

su-ex added a commit to SchildiChat/element-web that referenced this issue Jul 31, 2023
* Improve Content-Security-Policy ([\element-hq#25210](element-hq#25210)).
* Add UIFeature.locationSharing to hide location sharing ([\element-hq#10727](matrix-org/matrix-react-sdk#10727)).
* Memoize field validation results ([\#10714](matrix-org/matrix-react-sdk#10714)).
* Commands for plain text editor ([\element-hq#10567](matrix-org/matrix-react-sdk#10567)). Contributed by @alunturner.
* Allow 16 lines of text in the rich text editors ([\element-hq#10670](matrix-org/matrix-react-sdk#10670)). Contributed by @alunturner.
* Bail out of `RoomSettingsDialog` when room is not found ([\#10662](matrix-org/matrix-react-sdk#10662)). Contributed by @kerryarchibald.
* Element-R: Populate device list for right-panel ([\element-hq#10671](matrix-org/matrix-react-sdk#10671)). Contributed by @florianduros.
* Make existing and new issue URLs configurable ([\element-hq#10710](matrix-org/matrix-react-sdk#10710)). Fixes element-hq#24424.
* Fix usages of ARIA tabpanel ([\element-hq#10628](matrix-org/matrix-react-sdk#10628)). Fixes element-hq#25016.
* Element-R: Starting a DMs with a user ([\element-hq#10673](matrix-org/matrix-react-sdk#10673)). Contributed by @florianduros.
* ARIA Accessibility improvements ([\element-hq#10675](matrix-org/matrix-react-sdk#10675)).
* ARIA Accessibility improvements ([\element-hq#10674](matrix-org/matrix-react-sdk#10674)).
* Add arrow key controls to emoji and reaction pickers ([\element-hq#10637](matrix-org/matrix-react-sdk#10637)). Fixes element-hq#17189.
* Translate credits in help about section ([\element-hq#10676](matrix-org/matrix-react-sdk#10676)).
* Fix: reveal images when image previews are disabled ([\element-hq#10781](matrix-org/matrix-react-sdk#10781)). Fixes element-hq#25271. Contributed by @kerryarchibald.
* Fix autocomplete not resetting properly on message send ([\element-hq#10741](matrix-org/matrix-react-sdk#10741)). Fixes element-hq#25170.
* Fix start_sso not working with guests disabled ([\element-hq#10720](matrix-org/matrix-react-sdk#10720)). Fixes element-hq#16624.
* Fix soft crash with Element call widgets ([\element-hq#10684](matrix-org/matrix-react-sdk#10684)).
* Send correct receipt when marking a room as read ([\element-hq#10730](matrix-org/matrix-react-sdk#10730)). Fixes element-hq#25207.
* Offload some more waveform processing onto a worker ([\element-hq#9223](matrix-org/matrix-react-sdk#9223)). Fixes element-hq#19756.
* Consolidate login errors ([\element-hq#10722](matrix-org/matrix-react-sdk#10722)). Fixes element-hq#17520.
* Fix all rooms search generating permalinks to wrong room id ([\element-hq#10625](matrix-org/matrix-react-sdk#10625)). Fixes element-hq#25115.
* Posthog properly handle Analytics ID changing from under us ([\element-hq#10702](matrix-org/matrix-react-sdk#10702)). Fixes element-hq#25187.
* Fix Clock being read as an absolute time rather than duration ([\element-hq#10706](matrix-org/matrix-react-sdk#10706)). Fixes element-hq#22582.
* Properly translate errors in `ChangePassword.tsx` so they show up translated to the user but not in our logs ([\element-hq#10615](matrix-org/matrix-react-sdk#10615)). Fixes element-hq#9597. Contributed by @MadLittleMods.
* Honour feature toggles in guest mode ([\element-hq#10651](matrix-org/matrix-react-sdk#10651)). Fixes element-hq#24513. Contributed by @andybalaam.
* Fix default content in devtools event sender ([\element-hq#10699](matrix-org/matrix-react-sdk#10699)). Contributed by @tulir.
* Fix a crash when a call ends while you're in it ([\element-hq#10681](matrix-org/matrix-react-sdk#10681)). Fixes element-hq#25153.
* Fix lack of screen reader indication when triggering auto complete ([\element-hq#10664](matrix-org/matrix-react-sdk#10664)). Fixes element-hq#11011.
* Fix typing tile duplicating users ([\element-hq#10678](matrix-org/matrix-react-sdk#10678)). Fixes element-hq#25165.
* Fix wrong room topic tooltip position ([\element-hq#10667](matrix-org/matrix-react-sdk#10667)). Fixes element-hq#25158.
* Fix create subspace dialog not working ([\element-hq#10652](matrix-org/matrix-react-sdk#10652)). Fixes element-hq#24882.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants