Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new backend APIs for adding-3pid-to-homeserver and binding-3pid-on-identity-server when they exist. #10839

Closed
7 tasks done
lampholder opened this issue Sep 12, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3462
Closed
7 tasks done

Use the new backend APIs for adding-3pid-to-homeserver and binding-3pid-on-identity-server when they exist. #10839

lampholder opened this issue Sep 12, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3462
Assignees
@jryans
Labels
A-Identity-Server Privacy T-Enhancement

Comments

@lampholder
Copy link
Member

lampholder commented Sep 12, 2019 •
edited by jryans
Loading

Defined in matrix-org/matrix-spec-proposals#2290

  • Detect whether HS supports MSC2290 (look for unstable flag m.separate_add_and_bind or API version r0.6.0)
  • Always show account 3PID section in Settings (even without IS) if the HS supports MSC2290
  • Add JS SDK support for POST /_matrix/client/r0/account/3pid/bind, POST /_matrix/client/r0/account/3pid/unbind, and POST /_matrix/client/r0/account/3pid/add
  • Add JS SDK support for POST /_matrix/identity/v2/validate/<medium>/requestToken
  • Implement new 3PID add flow for MSC2290 servers
  • Implement new 3PID bind flow for MSC2290 servers
  • Use /unstable prefix for APIs
@lampholder
Copy link
Member Author

Removes the need for finding client-side solutions for #10779 and #10823

This was referenced Sep 12, 2019
Closed
Closed
This was referenced Sep 16, 2019
Closed
Closed
@jryans jryans self-assigned this Sep 17, 2019
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Sep 18, 2019
@jryans
Add function to check for separate 3PID add and bind
2bfa891 
This adds a way to test for MSC2290 support on the homeserver with separate add
and bind functions. It checks the unstable feature flag as well as the upcoming
r0.6.0 spec version.

Part of element-hq/element-web#10839
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Sep 18, 2019
@jryans
Add separate add and bind HS APIs
b444aaa 
Part of element-hq/element-web#10839
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Sep 18, 2019
@jryans
Add MSISDN validation API on the IS
f256f04 
This API has existed for quite a while, but historically we've instead proxied
this request via the homeserver. As part of MSC2290 work, we are changing
approaches such that we will request tokens directly from the IS when binding
for discovery.

Part of element-hq/element-web#10839
This was referenced Sep 18, 2019
Merged
Closed
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 20, 2019
@jryans
Change to separate add and bind to guard 3PID account section
99b804d 
This changes to checking for HS support of separate add and bind when guarding
the 3PID account section.

For older HSes, we in fact always require an IS for add with bind param, so the
previous version of this was incorrect.

Part of element-hq/element-web#10839
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 20, 2019
@jryans
Use separate email add and bind flow for supporting HSes
ff69ad0 
This changes the paths used for binding emails for discovery to use the new
separate bind / unbind APIs on supporting servers.

Part of element-hq/element-web#10839
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 20, 2019
@jryans
Use separate MSISDN add and bind flow for supporting HSes
f9a09d2 
This changes the paths used for binding MSISDNs for discovery to use the new
separate bind / unbind APIs on supporting servers.

Fixes element-hq/element-web#10839
@jryans jryans mentioned this issue Sep 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Identity-Server Privacy T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use separate 3PID add and bind flow for supporting HSes matrix-org/matrix-react-sdk
2 participants
@jryans @lampholder