Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threepid_creds for registration and password reset still include id_server #10941

Closed
jryans opened this issue Sep 24, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3473
Closed

threepid_creds for registration and password reset still include id_server #10941

jryans opened this issue Sep 24, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3473
Assignees
@jryans
Labels
A-Identity-Server Privacy T-Defect

Comments

@jryans
Copy link
Collaborator

jryans commented Sep 24, 2019

When the HS doesn't require an IS for registration / password reset, we should not be sending one.
@jryans jryans self-assigned this Sep 24, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 24, 2019
@jryans
Remove id_server param for password reset
0c51e41 
For HSes that no longer need it, remove the id_server param from password reset.

Part of element-hq/element-web#10941
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 24, 2019
@jryans
Remove id_server for MSISDN registration
ec9e7f5 
For HSes that no longer need it, remove the id_server param when verifying
MSISDNs at registration.

Fixes element-hq/element-web#10941
@jryans jryans mentioned this issue Sep 24, 2019
Merged
@jryans jryans mentioned this issue Sep 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Identity-Server Privacy T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove id_server param from threepid_creds matrix-org/matrix-react-sdk
1 participant
@jryans