Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font smoothing doesn't match designs #11425

Closed
ara4n opened this issue Nov 19, 2019 · 5 comments
Closed

Font smoothing doesn't match designs #11425

ara4n opened this issue Nov 19, 2019 · 5 comments

Comments

@ara4n
Copy link
Member

ara4n commented Nov 19, 2019

Our new designs in Figma feel much lighter and airier than the reality in Chrome (on retina macOS). This looks to be because Figma runs with -webkit-font-smoothing: antialiased rather than -webkit-font-smoothing: subpixel-antialiased on retina screens, so @nadonomy has been picking weights/font-sizing and generally balancing the design in Figma... but the end result is then mangled by the browser.

TL;DR: we should try setting everything to -webkit-font-smoothing: antialiased and its -moz equivalent. Need to check it doesn't make this illegible on Windows, and on non-retina displays. (I think antialiased is the default for non-retina displays though, so it hopefully shouldn't break those)

@ara4n
Copy link
Member Author

ara4n commented Nov 19, 2019

Concretely (you'll need to view the images fullsize on a retina screen to see the differences):

Figma: (with experimental timeline font sizing which should be ignored):
figma

Reality in Chrome on Retina on macOS:
reality

Using font-smoothing: antialiased on retina macOS rather than the default (subpixel-antialiased):
reality-fixed

Or, zoomed: left is Figma, right is Chrome (today):

Screenshot 2019-11-19 at 11 39 50

The effect is further complicated by the bg colour not matching figma, which gives the effect of increasing weight also.

@ara4n
Copy link
Member Author

ara4n commented Nov 19, 2019

(i'm currently running in Chrome with -webkit-font-smoothing: antialiased on the body tag, and it's a marked improvement on Retina in terms of feeling lighter and crisper and prettier).

It's worth noting that we've tried playing with this in the past and screwed it up as per matrix-org/matrix-react-sdk@30bb7ee - it's unclear how/where the screwup is coming from this time. Perhaps it's that Sketch used one smoothing and Figma used the other, and so having rebalanced the font weighting in Figma, that's how we've got out of whack.

@jryans
Copy link
Collaborator

jryans commented Nov 19, 2019

MDN claims -webkit-font-smoothing / -moz-osx-font-smoothing only affect macOS, so Windows / Linux should be unaffected.

@turt2live
Copy link
Member

Yea, before (which is just auto in our app) and after on Windows it's still a ransom note:
image
image

@turt2live
Copy link
Member

Presumably fixed by matrix-org/matrix-react-sdk#3677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants