Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left-click on tray icon opens menu instead of show/hiding the window #11772

Closed
kindlyfire opened this issue Jan 4, 2020 · 30 comments
Closed

Comments

@kindlyfire
Copy link

Description

Left-clicking on the tray icon does not show/hide the Riot desktop app. Instead, it shows the menu that also shows up on right click.

As I understand it, other people in the Riot Web/Desktop room do not seem to have this issue.

Steps to reproduce

  • Start Riot
  • Left click the tray icon
  • Menu opens instead of Riot hiding itself

Version information

  • Platform: desktop
  • OS: Solus with Budgie
  • Version: 1.5.6 from the Solus repos
@foresto
Copy link

foresto commented Jan 22, 2020

Confirming. It is a hassle to fiddle with menus when I just want to open the chat window from the system tray / indicator icon. I should be able to just click it.

Tested on Xubuntu linux, using the Riot electron app downloaded today from the ubuntu repo. I don't know how to get it to tell me its version number.

@foresto
Copy link

foresto commented Jan 22, 2020

Probably a dupe of #7553.

@MazeChaZer
Copy link

A few weeks ago, left clicking opened Riot directly, but now I am also experiencing the same problem, now matter if left or right click, only the menu comes up. I'm using i3 with i3bar.

@t3chguy
Copy link
Member

t3chguy commented Feb 19, 2020

I believe the electron version was updated so its probably an upstream issue

@foresto
Copy link

foresto commented Feb 19, 2020

If it's an upstream issue, has somebody on the riot dev team reported the issue upstream?

@t3chguy
Copy link
Member

t3chguy commented Feb 19, 2020

I don't think anyone on the dev team can reproduce it on their machines and don't have time to set up i3 etc to reproduce it, do you get similar issues on any other modern electron apps?

@foresto
Copy link

foresto commented Jul 8, 2020

do you get similar issues on any other modern electron apps?

I don't use any other electron apps. Can you suggest one with which to test?

For the record, the tray icon was behaving correctly for several versions (left click opens window), until a recent upgrade broke it again (left click opens menu).

@akmandev
Copy link

I use CentOS 7 and have the same issue. It shows only the menu "Show/hide and Quit" on the left click

@herzenschein
Copy link

herzenschein commented Sep 13, 2020

I can reproduce this on openSUSE Tumbleweed/Krypton with Element from the official repo and the Plasma DE. libappindicator3 is installed.

Slack and Discord (both flatpaks) show the same behavior.

@t3chguy
Copy link
Member

t3chguy commented Sep 13, 2020

The official repo is Debian and Ubuntu only, so which repo did you use?

@herzenschein
Copy link

The official repo is Debian and Ubuntu only, so which repo did you use?

Sorry, it was a while since I installed it, I misremembered. I installed it from this repo which builds from the Fedora COPR. By official I actually meant a proper rpm package rather than a containerized one like flatpak.

@wincak
Copy link

wincak commented Dec 21, 2020

This is also an issue for as long as I remember on KDE Neon (based on Ubuntu) with the official package from:
https://packages.riot.im/debian/
I don't have any other Electron based applications to compare; libappindicator3 is installed, if that matters.

@shapirus
Copy link

FWIW, I have this issue on a current Debian Sid with KDE 5.20.5. I installed electron-desktop from https://packages.riot.im/debian/pool/main/e/element-desktop/ and it pulled libappindicator3 as a dependency.

@manuke42
Copy link

manuke42 commented May 22, 2021

I have the same issue in latest Kubuntu version. I found a workaround that's working for me from the Signal Issue (comment). For me it was:
$ sudo touch /opt/Element/libappindicator3.so
$ sudo touch /opt/Element/libappindicator3.so.1

Now left clicking the tray icon of Element opens and hides the window directly instead of just opening the context menu.

@heini
Copy link

heini commented May 22, 2021

Thanks, @manuke42, works for me too.
Maybe worth mentioning: One has to restart Element after creating the files.

@foresto
Copy link

foresto commented May 22, 2021

I hereby confirm the libappindicator3 workaround on Xubuntu 20.04 when applied to the flatpak build of Element.

Adding these lines to the build-commands in im.riot.Riot.json did the trick:

"touch /app/Element/libappindicator3.so.1",
"ln -s libappindicator3.so.1 /app/Element/libappindicator3.so",

@enigma9o7
Copy link

This issue still present in 1.9.6, although touching those files does resolve it.

@Jieiku
Copy link

Jieiku commented Jul 3, 2022

This is no longer fixed by touching those files, back to being an issue.

I am on latest Manjaro KDE Plasma.

@Solarunit
Copy link

I wanted to create an issue about this problem, but it turned out there is an old one.
I hope it will be fixed some day.
I am using Solus Budgie.

@shapirus
Copy link

shapirus commented Aug 23, 2022

It can [only, I'm afraid] be fixed by moving to a different toolkit (for example, QT) that is not made of a pile of garbage code like Electron is.

@foresto
Copy link

foresto commented Sep 6, 2022

This is no longer fixed by touching those files, back to being an issue.
I am on latest Manjaro KDE Plasma.

Still works for me with the latest freedesktop (flatpak) runtime, built from the latest official deb package, by adding these steps to the flatpak build-commands section:

  - touch /app/Element/libappindicator3.so.1
  - ln -s libappindicator3.so.1 /app/Element/libappindicator3.so

@t3chguy
Copy link
Member

t3chguy commented Oct 26, 2022

Upstream issue electron/electron#14941

@autoteelar
Copy link

does anyone know if those workarounds still work?

@autoteelar
Copy link

well, seems to need to be recompiled anyways with that workaround from the short read i did, imo not too worth it since element releases are pretty frequent, would have to do it every time

@autoteelar
Copy link

It can [only, I'm afraid] be fixed by moving to a different toolkit (for example, QT) that is not made of a pile of garbage code like Electron is.

honestly from the last time i used nheko, im happy with electron

qt would be nice though i like GTK better, themes look better

@yennor
Copy link

yennor commented Oct 26, 2022

no need to recompile it.
executing once

touch /opt/Element/libappindicator3.so
touch /opt/Element/libappindicator3.so.1

works. even after updates. At least under debian.
Still, incredibly annoying bug.

@foresto
Copy link

foresto commented Oct 26, 2022

Similarly, adding this to the flatpak build-commands section still works:

  - touch /app/Element/libappindicator3.so.1
  - ln -s libappindicator3.so.1 /app/Element/libappindicator3.so

(Tested just now with Element 1.11.11 on KDE 5.20.5, Debian Stable)

@autoteelar
Copy link

hi thanks for the reply!

Adding these lines to the build-commands in im.riot.Riot.json did the trick:

"touch /app/Element/libappindicator3.so.1",
"ln -s libappindicator3.so.1 /app/Element/libappindicator3.so",

i saw you posted this earlier,

how exactly can i do that? i cant find a im.riot.Riot.json did anywhere

@foresto
Copy link

foresto commented Oct 27, 2022

how exactly can i do that? i cant find a im.riot.Riot.json did anywhere

That variant of the workaround is for people who build the flatpak themselves. I did it using flathub's manifest, which is a yaml file, not json. (It packages the official element.io .deb file's Element binary.)

@t3chguy
Copy link
Member

t3chguy commented Dec 6, 2022

Fixed in Electron 22 - element-hq/element-desktop#480 (comment)

@t3chguy t3chguy closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests