Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon left click click behaviour #23606

Closed
autoteelar opened this issue Oct 26, 2022 · 7 comments
Closed

Change icon left click click behaviour #23606

autoteelar opened this issue Oct 26, 2022 · 7 comments

Comments

@autoteelar
Copy link

autoteelar commented Oct 26, 2022

Your use case

What would you like to do?

make left click toggle hide/show app

Why would you like to do it?

because it makes more sense and every other app does it

How would you like to achieve it?

make right click stay the same, but instead of making left click a copy of what right click does, just make it quickly show/hide

you can also very accidentially close the app accidentially just by clicking once, as linux has some weird feature wher eyour mouse clicks stay until release.

tldr is just extremely annoying like that and i think it should be this way. i see absolutely 0 downsides and only upsides to changing this.

Have you considered any alternatives?

No response

Additional context

No response

@autoteelar
Copy link
Author

simply just double clicking the icon as of now quits it, as the quit button spawns right under the mouse, although this is a WM thing, its still impractical and worth mentioning again another reason why this change is important to end users

@t3chguy
Copy link
Member

t3chguy commented Oct 26, 2022

make left click toggle hide/show app

This is how it is programmed to work, but the various compatibility layers in Electron/Chromium make it not behave as expected sometimes.

https://github.com/vector-im/element-desktop/blob/develop/src/tray.ts#L61

This is an upstream issue electron/electron#14941

@autoteelar
Copy link
Author

thank you t3chguy, so its an electron thing and its already coded in element nice, hopefully we see these things worked out :)

@autoteelar
Copy link
Author

wow, its been an unresolved issue for 4 years though, shouldnt that be an extremely easy fix? should take a few minutes letalone 4 years

@t3chguy
Copy link
Member

t3chguy commented Oct 26, 2022

Duplicate of #11772

@t3chguy t3chguy marked this as a duplicate of #11772 Oct 26, 2022
@t3chguy t3chguy closed this as completed Oct 26, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2022
@t3chguy
Copy link
Member

t3chguy commented Oct 26, 2022

@autoteelar unfortunately not, Linux has multiple tray icon implementations, fixing one will regress another, Element also relies on Electron handling it given handling all the world's tray icon implementations ourselves would expend a lot of developer time.

@autoteelar
Copy link
Author

autoteelar commented Oct 26, 2022

i guess things are just more complicated than the surface level appears to be, thanks for sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants