Support HTTP Basic Auth on custom homeserver url #12136
Comments
|
I think this will conflict with the Auth system in Matrix which also uses the |
|
FYI, stepping through the JS, it seems that the user:password is being scrubbed from the url in _sanitizeWellKnownUrl here: https://github.com/matrix-org/matrix-js-sdk/blob/0f1f18b23291124489000a61ff1f0e69e379326a/src/autodiscovery.js#L243 |
|
that's for wellknown discovery, if you manually enter a HS url then this isn't the right codepath |
|
I assume this would at least require a spec change @turt2live? If so, then the spec process seems like a better place for this. |
|
Yea, it would be a fairly significant spec change. Closing this for now in favour of an MSC (https://matrix.org/docs/spec/proposals) |
* Add `Thread Activity centre` labs flag * Rename translation string * WIP Thread Activity Centre * Update supportedLevels * css lint * i18n lint * Fix labs subsection test * Update Threads Activity Centre label * Rename Thread Activity Centre to Threads Activity Centre * Use compound `MenuItem` instead of custom button * Color thread icon when hovered * Make the pop-up scrollable and add a max height * Remove Math.random in key * Remove unused class * Change add comments on `mx_ThreadsActivityRows` and `mx_ThreadsActivityRow` * Make threads activity centre labs flag split out unread counts Just shows notif & unread counts for main thread if the TAC is enabled. * Fix tests * Simpler fix * Open thread panel when thread clicke in Threads Activity Centre Hopefully this is a sensible enough way. The panel will stay open of course (ie. if you go to a different room & come back), but that's the nature of the right panel. * Dynamic state of room * Add doc * Use the StatelessNotificationBadge component in ThreadsActivityCentre and re-use the existing NotificationLevel * Remove unused style * Add room sorting * Fix `ThreadsActivityRow` props doc * Pass in & cache the status of the TAC labs flag * Pass includeThreads as setting to doesRoomHaveUnreadMessages too * Fix tests * Add analytics to the TAC (#12179) * Update TAC label (#12186) * Add `IndicatorIcon` to the TAC button (#12182) Add `IndicatorIcon` to the TAC button * Threads don't have activity if the room is muted This makes it match the computation in determineUnreadState. Ideally this logic should all be in one place. * Re-use doesRoomHaveUnreadThreads for useRoomThreadNotifications This incorporates the logic of not showing unread dots if the room is muted * Add TAC description in labs (#12197) * Fox position & size of dot on the tac button IndicatorIcon doesn't like having the size of its icon adjusted and we probably shouldn't do it anyway: better to specify to the component what size we want it. * TAC: Utils tests (#12200) * Add tests for `doesRoomHaveUnreadThreads` * Add tests for `getThreadNotificationLevel` * Add test for the ThreadsActivityCentre component * Add snapshot test * Fix narrow hover background on TAC button Make the button 32x32 (and the inner icon 24x24) * Add caption for empty TAC * s/tac/threads_activity_centre/ * Fix i18n & add tests * Add playwright tests for the TAC (#12227) * Fox comments --------- Co-authored-by: David Baker <dbkr@users.noreply.github.com>
Is your suggestion related to a problem? Please describe.
I'm trying to run my own matrix homeserver, secured by HTTP Basic Authentication. When I enter a custom homeserver url in the riot.im web app, e.g.
https://user:pass@example.com, it seems to strip out the user and password, so its requests to the homeserver all fail with status 401.Describe the solution you'd like
the webapp should support HTTP basic auth.
Describe alternatives you've considered
I also tried the riot and riotX android apps, and they also don't seem to work with basic auth.
I'm currently not able to host the matrix server in my environment without basic auth.
Additional context
I would be happy to try to send a PR for this feature, if it would be welcome.
The text was updated successfully, but these errors were encountered: