Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac shortcuts: Cmd-, should open user settings #12246

Closed
jryans opened this issue Feb 5, 2020 · 5 comments · Fixed by #12800
Closed

Mac shortcuts: Cmd-, should open user settings #12246

jryans opened this issue Feb 5, 2020 · 5 comments · Fixed by #12800
Assignees
@t3chguy
Labels
A-Electron A-Shortcuts Keyboard shortcuts T-Enhancement Z-Mozilla Z-Platform-Specific

Comments

@jryans
Copy link
Collaborator

jryans commented Feb 5, 2020

On macOS, users expect Cmd-, to open the app's settings window. We should add this shortcut to Riot Desktop on macOS. Ideally there would also be a "Preferences..." item in the app menu as well.
@madduck
Copy link

madduck commented Feb 5, 2020

Please make it configurable

@aaronraimist
Copy link
Collaborator

@madduck all shortcuts are configurable in macOS, Riot doesn't need to provide any special support for it.

@nadonomy
Copy link
Contributor

On macOS, users expect Cmd-, to open the app's settings window

@jryans can you clarify this? I'd expect CMD + - to zoom out? The macOS keyboard shortcut for settings is normally CMD + ,.

@jryans
Copy link
Collaborator Author

jryans commented Feb 10, 2020 •
edited
Loading

@nadonomy We are agreeing, I was using - as the separator between keys and the comma was part of the key sequence. The sequence is indeed "hold Cmd, press comma".

@t3chguy
Copy link
Member

t3chguy commented Feb 10, 2020 •
edited
Loading

In a browser app should this open the settings of the browser or the app therein? /me rereads OP to see Riot Desktop

@t3chguy t3chguy self-assigned this Mar 19, 2020
@t3chguy t3chguy mentioned this issue Mar 19, 2020
Merged
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@florianduros
Use browser's font size instead of hardcoded 16px as root font size (…
6d55ce0 
…#12246)

* WIP Use browser font size instead of hardcoded 16px

* Add font migration to v3

* Remove custom font size input

* Use a dropdown instead of a slider

* Add margin to the font size dropdown

* Fix `UpdateFontSizeDelta` action typo

* Fix `fontScale`in `Call.ts`

* Rename `baseFontSizeV3` to `fontSizeDelta`

* Update playwright test

* Add `default` next to the browser font size

* Remove remaining `TODO`

* Remove falsy `private`

* Improve doc

* Update snapshots after develop merge

* Remove commented import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Electron A-Shortcuts Keyboard shortcuts T-Enhancement Z-Mozilla Z-Platform-Specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Register Mac electron specific Cmd+, shortcut to User Settings element-hq/element-web
5 participants
@madduck @jryans @t3chguy @nadonomy @aaronraimist