Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MELS can collapse days too #12469

Closed
turt2live opened this issue Feb 21, 2020 · 4 comments · Fixed by matrix-org/matrix-react-sdk#4152
Closed

MELS can collapse days too #12469

turt2live opened this issue Feb 21, 2020 · 4 comments · Fixed by matrix-org/matrix-react-sdk#4152
Assignees
@t3chguy
Labels
A-Timeline P1 T-Defect X-Regression

Comments

@turt2live
Copy link
Member

image

Here we see part of a MELS that started on Tuesday (as the header implies), but person 187 joined on Thursday which is why the timestamps make no sense.

MELS shouldn't be able to pass the day boundary, or the day boundary should be in the MELS.
@t3chguy
Copy link
Member

t3chguy commented Feb 21, 2020

this may be a regression from the recent changes in the area

@turt2live turt2live self-assigned this Feb 21, 2020
@turt2live turt2live removed their assignment Feb 21, 2020
@turt2live
Copy link
Member Author

Which area? There's quite a bit of areas that lead up to this.

@t3chguy
Copy link
Member

t3chguy commented Feb 21, 2020

@turt2live matrix-org/matrix-react-sdk#4059

@turt2live
Copy link
Member Author

ah, hmm... possibly. I'll tag this as p1 for now but not a fire.

@turt2live turt2live added the P1 label Feb 21, 2020
@t3chguy t3chguy self-assigned this Feb 29, 2020
@t3chguy t3chguy mentioned this issue Feb 29, 2020
Merged
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@renovate
Update dependency @sentry/browser to v7.112.2 (#12469)
016533b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Timeline P1 T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MELS not breaking on day boundaries regression matrix-org/matrix-react-sdk
2 participants
@turt2live @t3chguy