Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build release electron app with auto builder #12707

Closed
dbkr opened this issue Mar 12, 2020 · 2 comments · Fixed by element-hq/element-builder#23
Closed

Build release electron app with auto builder #12707

dbkr opened this issue Mar 12, 2020 · 2 comments · Fixed by element-hq/element-builder#23
Assignees
@jryans
Labels
A-E2EE-Cross-Signing

Comments

@dbkr
Copy link
Member

dbkr commented Mar 12, 2020

When the auto-builder finishes building a riot-web tarball (ie. making the github release) build the release electron app and upload it to packages in the same way as we do for nightly builds.

Blocked on neon-bindings/neon#491 for 32 bit support
Split out from #12452
@dbkr dbkr mentioned this issue Mar 12, 2020
Closed
12 tasks
@jryans jryans self-assigned this Apr 14, 2020
@jryans jryans mentioned this issue Apr 15, 2020
Closed
@jryans
Copy link
Collaborator

jryans commented Apr 15, 2020

The Windows 32-bit portion has been deferred to after release, tracked in #13175.

I'm taking a slightly different approach to this for the moment to save time: the auto-builder pulls the tarball from GitHub which was previously assembled by the build laptop.

@jryans jryans mentioned this issue Apr 15, 2020
Merged
@jryans
Copy link
Collaborator

jryans commented Apr 15, 2020

Fixed by element-hq/element-builder#23

@jryans jryans closed this as completed Apr 15, 2020
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@RiotRobot @github-merge-queue
[create-pull-request] automated change (#12707)
b449dc8 
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-E2EE-Cross-Signing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build release version of Riot Desktop element-hq/element-builder
2 participants
@jryans @dbkr