Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No feedback when leaving a room fails #14999

Closed
turt2live opened this issue Aug 19, 2020 · 0 comments · Fixed by matrix-org/matrix-react-sdk#5132
Closed

No feedback when leaving a room fails #14999

turt2live opened this issue Aug 19, 2020 · 0 comments · Fixed by matrix-org/matrix-react-sdk#5132
Assignees
@turt2live
Labels
P1 T-Defect

Comments

@turt2live
Copy link
Member

No description provided.

@turt2live turt2live self-assigned this Aug 19, 2020
@t3chguy t3chguy added the ui/ux label Aug 19, 2020
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 20, 2020
@turt2live
Run all room leaving behaviour through a single function
e0b8343 
Fixes element-hq/element-web#14999
Fixes element-hq/element-web#10380

We were failing to handle errors when `/part`ing a room, though the leave room button was fine. This runs both the button and command through the same function for handling, including the 'view next room' behaviour.
@turt2live turt2live mentioned this issue Aug 20, 2020
Merged
@jryans jryans removed the Z-UI/UX label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P1 T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run all room leaving behaviour through a single function matrix-org/matrix-react-sdk
3 participants
@jryans @turt2live @t3chguy