-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache in service worker for offline experience #18147
Comments
It was causing updates to not happen due to it disagreeing that an update was needed, given how we have our version just in a loose text file, I think it'd need to be embedded into the code for this to work better. |
So just change the handler to Or better, |
StaleWhileRevalidate didn't work for the automatic update prompt that came up in the app and workbox offered no sane way to override it. We either have to work the update prompt around the service worker or vice versa, out of the box neither likes the other |
Aha, so a hand written service worker is the way to go? Or workbox without webpack plugin? Or making changes in versioning system? |
One of the above, I'd kinda prefer using a solid approach like workbox and improving our versioning/update mechanism given it is very naive and basic atm (just watches a |
Duplicate of #7984 |
Currently there is just an empty service worker. It seems there was a functional service worker, but it is removed in cfee4c9#diff-1fb26bc12ac780c7ad7325730ed09fc4c2c3d757c276c3dacc44bfe20faf166f and reverted. Why? It is useful for faster initial times and better experience for network problems.
The text was updated successfully, but these errors were encountered: