Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workbox #15352

Merged
merged 5 commits into from
Oct 1, 2020
Merged

Remove workbox #15352

merged 5 commits into from
Oct 1, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 1, 2020

Due to how we handle updates and versioning it became quite problematic, the solution will need more experimentation.

Reverts #15196 #15271 #15345

sw.js will be registered over service-worker.js, replacing it.

t3chguy added 5 commits October 1, 2020 14:04
@t3chguy
Revert "consolidate"
daa7550 
This reverts commit aa2f391

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Revert "Disable workbox when running in webpack dev server, not in de…
87c4293 
…v mode"

This reverts commit 11e676c

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Revert "Tidy up Service Worker, only run Workbox in production"
1edbe36 
This reverts commit c47532f

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Revert "Attempt to fix tests some more"
cfee4c9 
This reverts commit c76a5f2

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Update yarn.lock
ad95d1f 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team October 1, 2020 13:08
@t3chguy t3chguy mentioned this pull request Oct 1, 2020
Closed
jryans
jryans approved these changes Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, l agree this seems like the correct step for now. Once we've got the issues sorted out, we can try again.

@t3chguy t3chguy merged commit 7b71db9 into develop Oct 1, 2020
@t3chguy t3chguy deleted the t3chguy/remove-workbox branch October 1, 2020 13:48
@t3chguy t3chguy mentioned this pull request Jul 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @jryans