Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable workbox when running in webpack dev server, not in dev mode #15345

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Disable workbox when running in webpack dev server, not in dev mode #15345

merged 2 commits into from
Sep 30, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Sep 30, 2020

No description provided.

@t3chguy
Disable workbox when running in webpack dev server, not in dev mode
11e676c 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
consolidate
aa2f391 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team September 30, 2020 16:37
jryans
jryans approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me as well, thanks! 😄

@t3chguy t3chguy merged commit ca78985 into develop Sep 30, 2020
@t3chguy t3chguy deleted the t3chguy/fix/workbox branch September 30, 2020 18:26
@t3chguy t3chguy mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t3chguy @jryans @turt2live