Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloading is mislabeled #18239

Closed
nadonomy opened this issue Jul 26, 2021 · 0 comments · Fixed by matrix-org/matrix-react-sdk#6509
Closed

Downloading is mislabeled #18239

nadonomy opened this issue Jul 26, 2021 · 0 comments · Fixed by matrix-org/matrix-react-sdk#6509
Assignees
@turt2live
Labels
A-File-Download A-Voice-Messages P1 Sponsored T-Defect

Comments

@nadonomy
Copy link
Contributor

nadonomy commented Jul 26, 2021 •
edited
Loading

Screenshot 2021-07-26 at 17 27 06

While trying to download a large file in an encrypted room, the spinner & tooltip displays 'Downloading' while it's presumably Decrypting. I thought the download was failing as our UI was telling me it's downloading while my browser wasn't.

The in-context spinner & tooltip feel great, though!
@turt2live turt2live self-assigned this Jul 26, 2021
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 29, 2021
@turt2live
Change "Downloading" tooltip to "Decrypting"
d1e7c79 
Fixes element-hq/element-web#18239
@turt2live turt2live mentioned this issue Jul 29, 2021
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 29, 2021
@turt2live
Change "Downloading" tooltip to "Decrypting"
790696a 
Fixes element-hq/element-web#18239
@anoadragon453 anoadragon453 mentioned this issue Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-File-Download A-Voice-Messages P1 Sponsored T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve download interactions matrix-org/matrix-react-sdk
3 participants
@turt2live @nadonomy @SimonBrandner