Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly does not work with ozone (wayland native) #18902

Closed
HarHarLinks opened this issue Sep 4, 2021 · 7 comments
Closed

Nightly does not work with ozone (wayland native) #18902

HarHarLinks opened this issue Sep 4, 2021 · 7 comments
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect

Comments

@HarHarLinks
Copy link
Contributor

Steps to reproduce

Stable supports running in wayland native like this: element-desktop --enable-features=UseOzonePlatform --ozone-platform=wayland. Doing the same with element-desktop-nightly apparently does not. Maybe because bundles its own electron (assumption based on no dependency in the pkg)?

This is on sway 1.6.1.

What happened?

What did you expect?

element works as usual

What happened?

no window, only the indicator icon appears.

Operating system

arch

Application version

Element Nightly version: 2021090301 Olm version: 3.2.3

How did you install the app?

aur/element-desktop-nightly-bin

Homeserver

own

Have you submitted a rageshake?

No

@dbkr
Copy link
Member

dbkr commented Sep 6, 2021

This isn't one of our packages I'm afraid - I'm not sure we can really help much unless it's just a case of it using a different electron version or something perhaps? Although we are fairly up to date.

@HarHarLinks
Copy link
Contributor Author

HarHarLinks commented Sep 7, 2021 via email

@SimonBrandner SimonBrandner added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround labels Sep 10, 2021
@SimonBrandner
Copy link
Contributor

Perhaps this was caused by element-hq/element-desktop#256 as @yu-re-ka suggests in element-hq/element-desktop#256 (comment). @yu-re-ka, what leads you to think that was the change that broke Element with Wayland?

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Sep 10, 2021

@yu-re-ka and @HarHarLinks, does the Jitsi desktop app work for you?

@yu-re-ka
Copy link

The described failure mode matches what I have observed.

element-hq/element-desktop#256 adds a --enable-features WebRTCPipeWireCapturer flag to the electron cmdline. However @HarHarLinks and I set this flag as well, so effectively electron gets started with --enable-features WebRTCPipeWireCapturer --enable-features UseOzonePlatform and Chromium/Electron don't support passing the flag multiple times.

This should be fixed by element-hq/element-desktop#261, but the build date of the nightly package suggests it doesn't include the fix.
The Jitsi desktop app had the same problem.

@SimonBrandner
Copy link
Contributor

Ah, great thanks for the explanation! Let's assume this is fixed now. Let me know if you ever see this again

@HarHarLinks
Copy link
Contributor Author

It does seem to work in principle now. I'm noticing a last small problem: when running with ozone, the window_properties field is missing. This contains a bunch of meta info to identify the program and is commonly used to e.g. assign apps to fixed workspaces. Consequently my condition that moves windows with class beginning in Element to a certain workspace.
get_tree with ozone:

            {
              "id": 23,
              "type": "con",
              "orientation": "none",
              "percent": 1.0,
              "urgent": false,
              "marks": [
              ],
              "focused": false,
              "layout": "none",
              "border": "normal",
              "current_border_width": 2,
              "rect": {
                "x": 0,
                "y": 415,
                "width": 1920,
                "height": 1025
              },
              "deco_rect": {
                "x": 0,
                "y": 0,
                "width": 1920,
                "height": 25
              },
              "window_rect": {
                "x": 0,
                "y": 0,
                "width": 1920,
                "height": 1025
              },
              "geometry": {
                "x": 0,
                "y": 0,
                "width": 1024,
                "height": 768
              },
              "name": "Element Nightly [1] | Room Name",
              "window": null,
              "nodes": [
              ],
              "floating_nodes": [
              ],
              "focus": [
              ],
              "fullscreen_mode": 0,
              "sticky": false,
              "pid": 4509,
              "app_id": "Element-Nightly",
              "visible": true,
              "max_render_time": 0,
              "shell": "xdg_shell",
              "inhibit_idle": false,
              "idle_inhibitors": {
                "user": "none",
                "application": "none"
              }
            }

with Xwayland:

            {
                  "id": 27,
                  "type": "con",
                  "orientation": "none",
                  "percent": 1.0,
                  "urgent": false,
                  "marks": [
                  ],
                  "focused": false,
                  "layout": "none",
                  "border": "normal",
                  "current_border_width": 2,
                  "rect": {
                    "x": 0,
                    "y": 415,
                    "width": 1920,
                    "height": 1025
                  },
                  "deco_rect": {
                    "x": 0,
                    "y": 0,
                    "width": 1920,
                    "height": 25
                  },
                  "window_rect": {
                    "x": 0,
                    "y": 0,
                    "width": 1920,
                    "height": 1025
                  },
                  "geometry": {
                    "x": 0,
                    "y": 0,
                    "width": 1024,
                    "height": 768
                  },
                  "name": "Element Nightly [1] | Room Name",
                  "window": 23068673,
                  "nodes": [
                  ],
                  "floating_nodes": [
                  ],
                  "focus": [
                  ],
                  "fullscreen_mode": 0,
                  "sticky": false,
                  "pid": 7935,
                  "app_id": null,
                  "visible": true,
                  "max_render_time": 0,
                  "shell": "xwayland",
                  "inhibit_idle": false,
                  "idle_inhibitors": {
                    "user": "none",
                    "application": "none"
                  },
                  "window_properties": {
                    "class": "Element-Nightly",
                    "instance": "element-nightly",
                    "title": "Element Nightly [1] | Room Name",
                    "transient_for": null,
                    "window_role": "browser-window",
                    "window_type": "normal"
                  }
                }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants