Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up arrow key to edit events when thread view is open #18981

Closed
germain-gg opened this issue Sep 10, 2021 · 0 comments · Fixed by matrix-org/matrix-react-sdk#6877
Closed

Fix up arrow key to edit events when thread view is open #18981

germain-gg opened this issue Sep 10, 2021 · 0 comments · Fixed by matrix-org/matrix-react-sdk#6877
Assignees
@Palid
Labels
A-Composer A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Milestone
App Team 1.9.1

Comments

@germain-gg
Copy link
Contributor

Steps to reproduce

  1. Enable threaded messages
  2. Open a thread
  3. Hit up arrow when focusing on the thread view composer instance

What happened?

What did you expect?

For it to toggle the edit state of the message on the timeline above

What happened?

It is broken in various creative ways, because the composer was not built with that in mind

Operating system

No response

Browser information

No response

URL for webapp

No response

Homeserver

No response

Have you submitted a rageshake?

No
@germain-gg germain-gg added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Composer O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Threads labels Sep 10, 2021
@germain-gg germain-gg modified the milestones: Spaces Beta, App Team 1.8.4 Sep 10, 2021
@novocaine novocaine modified the milestones: App Team 1.8.6, App Team 1.8.7 Sep 22, 2021
@novocaine novocaine mentioned this issue Sep 25, 2021
Closed
@daniellekirkwood daniellekirkwood mentioned this issue Sep 29, 2021
Closed
@Palid Palid mentioned this issue Sep 29, 2021
Merged
@Palid Palid mentioned this issue Oct 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Palid Palid

Labels
A-Composer A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
App Team 1.9.1
Development

Successfully merging a pull request may close this issue.

Add ability to properly edit messages in Threads. matrix-org/matrix-react-sdk
3 participants
@novocaine @germain-gg @Palid