This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add ability to properly edit messages in Threads. #6877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
suggested changes
Sep 30, 2021
There was a problem hiding this comment.
That looks really good 👏
Couple of minor changes, but that should be good to go after that.
The arrow keys logic with the composer is fixed, however there's an issue where redaction are not partitioned correctly and when editing a message in the thread view, the redaction event ends up in the main room timeline
I've created another ticket to track this issue, check element-hq/element-web#19229
Edit: the linter and the tests need appeasement
src/contexts/MatrixClientContext.tsx
Outdated
| @@ -0,0 +1,46 @@ | |||
| /* | |||
| Copyright 2019 The Matrix.org Foundation C.I.C. | |||
There was a problem hiding this comment.
The copyright is incorrect here
Palid
added
the
T-Enhancement
Co-authored-by: Germain <germains@element.io>
added 12 commits
October 1, 2021 14:13
Palid
force-pushed
the
palid/feature/threads/18981
branch
from
301b86a
to
489cb63
Compare
germain-gg
approved these changes
Oct 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix element-hq/element-web#18981
Here's what your changelog entry will look like:
✨ Features
Preview: https://61570d9a7e599d00d5170c41--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.