Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message action bar for threaded events #19127

Closed
Tracked by #3
germain-gg opened this issue Sep 22, 2021 · 4 comments · Fixed by matrix-org/matrix-react-sdk#6873
Closed
Tracked by #3

Add message action bar for threaded events #19127

germain-gg opened this issue Sep 22, 2021 · 4 comments · Fixed by matrix-org/matrix-react-sdk#6873
Assignees
Labels
A-Threads T-Task Tasks for the team like planning

Comments

@germain-gg
Copy link
Contributor

Make sure we re-use the same message action bar as in the room timeline.

We will need to exclude some actions when an event is displayed in a thread context

I believe we need to exclude

  • Reply to event
  • Reply in thread

@janogarcia could you confirm whether anything else springs to mind

@germain-gg germain-gg added T-Task Tasks for the team like planning A-Threads labels Sep 22, 2021
@germain-gg germain-gg self-assigned this Sep 22, 2021
@germain-gg germain-gg added this to the App Team 1.8.7 milestone Sep 22, 2021
@janogarcia
Copy link

janogarcia commented Sep 22, 2021

@gsouquet Regular replies wouldn't be excluded actually. Please refer to these two frames, where you can find examples of the popover menus for the different cases. 👍

03b Thread actions — The Thread Actions popover is revealed on click (root message and message author)
https://www.figma.com/file/T309ztx0sNyOOK6NKVLHsK/Threads?node-id=788%3A266820
Screen Shot 2021-09-23 at 14 47 39

03c Thread actions — The Thread Actions popover is revealed on click (non root message, no message author)
https://www.figma.com/file/T309ztx0sNyOOK6NKVLHsK/Threads?node-id=788%3A269782
Screen Shot 2021-09-23 at 14 47 42

@germain-gg
Copy link
Contributor Author

What does the reply button do in that context then? Is it a shortcut to broadcast the answer to the main room timeline too?
Or do you expect to see the message replied to quoted in the thread view?

@janogarcia
Copy link

Oh, the second one. That is, keeping the ability to quote-reply to individual messages in a thread. Those replies would live within the context of the thread. If we ever add the ability to broadcast specific messages to the room timeline that would be a separate feature, unrelated to this one. 👍

@germain-gg
Copy link
Contributor Author

Leaving the "reply" button out for now as the current thread's implementation does not allow you to have quote replies in the thread view, tracked as part of #19161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants