Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add MessageActionBar to ThreadView #6873

Merged
merged 4 commits into from
Sep 28, 2021

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Sep 28, 2021

Fixes element-hq/element-web#19127

Uses the exact same design as production for now

Screen Shot 2021-09-28 at 09 45 27


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Preview: https://615321038269f64bf67389c0--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@germain-gg germain-gg requested a review from a team as a code owner September 28, 2021 08:49
Copy link
Contributor

@Palid Palid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just have a look at the suggestion please, so we can save ourselves some hassle in the future. There's also one accidental line removal.

src/components/views/messages/MessageActionBar.tsx Outdated Show resolved Hide resolved
src/components/views/rooms/EventTile.tsx Show resolved Hide resolved
@germain-gg germain-gg merged commit ca3b8e5 into develop Sep 28, 2021
@germain-gg germain-gg deleted the gsouquet/threads-action-bar-19127 branch September 28, 2021 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add message action bar for threaded events
2 participants