Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map in location sharing doesn't draw #20655

Closed
lnicola opened this issue Jan 20, 2022 · 11 comments · Fixed by matrix-org/matrix-react-sdk#7982
Closed

Map in location sharing doesn't draw #20655

lnicola opened this issue Jan 20, 2022 · 11 comments · Fixed by matrix-org/matrix-react-sdk#7982
Labels
A-Location-Sharing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter X-Needs-Investigation Z-Labs

Comments

@lnicola
Copy link

lnicola commented Jan 20, 2022

Steps to reproduce

  1. Enable location sharing in Labs
  2. Click the share location button
  3. If prompted by the browser give location access to the page

Outcome

What did you expect?

A map.

What happened instead?

No map and a warning:

image

WebGL warning: texImage: Alpha-premult and y-flip are deprecated for non-DOM-Element uploads.

Operating system

Linux

Browser information

Firefox 98.0a1 (2022-01-19)

URL for webapp

self-hosted 1.9.9

Application version

No response

Homeserver

No response

Will you send logs?

No
@dbkr dbkr added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Needs-Investigation labels Jan 21, 2022
@t3chguy
Copy link
Member

t3chguy commented Jan 24, 2022

Do you have the API Key in config.json?

https://github.com/vector-im/element-web/blob/develop/docs/config.md 36 map_style_url

@SimonBrandner SimonBrandner added the X-Needs-Info This issue is blocked awaiting information from the reporter label Jan 24, 2022
@lnicola
Copy link
Author

lnicola commented Jan 24, 2022

Thanks. I checked the sample config, but this key isn't there yet, of course. It might be worth printing a console message if the URL is empty.

@lnicola lnicola closed this as completed Jan 24, 2022
@t3chguy
Copy link
Member

t3chguy commented Jan 24, 2022

It'd be better if the button was not available if there was no API Key - @andybalaam

@lnicola
Copy link
Author

lnicola commented Jan 24, 2022

The problem with that is you won't know what to do if it's not working. At lease there should be a tooltip or error message.

@t3chguy
Copy link
Member

t3chguy commented Jan 24, 2022

But its not an error that an end-user can do anything about, its one for the (tiny) subset of users which are the operator of that Element instance

@t3chguy
Copy link
Member

t3chguy commented Jan 24, 2022

We do the same for rageshakes ftr, if there's no submit logs url in the config.json the button just vanishes

@andybalaam
Copy link
Contributor

There is definitely intended to be a console log message about this. I will check that first, then think about the other questions.

@andybalaam
Copy link
Contributor

OK, I found the bug meaning that no error message is shown. It will be fixed in matrix-org/matrix-react-sdk#7623 . As for not showing the button if the config is missing - we can handle this as a separate feature, but it's a little tricky because it affects all maps, not just sharing your own location, and it's really a problem that should be fixed by your server or client admin, rather than the user, so maybe a browser console message is the right way to handle it?

@t3chguy
Copy link
Member

t3chguy commented Jan 26, 2022

and it's really a problem that should be fixed by your server or client admin, rather than the user, so maybe a browser console message is the right way to handle it?

Your client admin doesn't tend to ever see the end user's console though, so a missing button would be a bit more clear as something a user might complain about

@lnicola
Copy link
Author

lnicola commented Jan 26, 2022

A missing button doesn't say anything. Maybe the feature isn't there (how could the user complain if they don't even know it's missing?). Maybe the feature is disabled. Maybe it's enabled but configured incorrectly. Maybe it's not working on some browser.

An error message can clear this up: "you tried to do X, it didn't work because Y".

@andybalaam
Copy link
Contributor

I am inclined to agree with @lnicola . I will feed this in to the design process - thank you.

@kerryarchibald kerryarchibald mentioned this issue Mar 4, 2022
Merged
su-ex added a commit to SchildiChat/element-web that referenced this issue Apr 1, 2022
@su-ex
Merge tag 'v1.10.8' into sc
2c28fa8 
* Live location sharing: live share warning in room ([\element-hq#8100](matrix-org/matrix-react-sdk#8100)).
* Add simple live share warning ([\element-hq#8066](matrix-org/matrix-react-sdk#8066)).
* extract reusable styled live beacon icon ([\element-hq#8103](matrix-org/matrix-react-sdk#8103)).
* Don't restore MemberInfo from RightPanel history when viewing a room ([\element-hq#8090](matrix-org/matrix-react-sdk#8090)). Fixes element-hq#21487.
* Allow sending files as replies as per MSC3676 ([\element-hq#8020](matrix-org/matrix-react-sdk#8020)). Fixes element-hq#7156.
* kill beacons on expiry ([\element-hq#8075](matrix-org/matrix-react-sdk#8075)).
* enable geolocation behaviour in location picker for live share type ([\element-hq#8068](matrix-org/matrix-react-sdk#8068)).
* Improve formatting features in the editor ([\#7104](matrix-org/matrix-react-sdk#7104)). Fixes element-hq#19501. Contributed by @alexanderstephan.
* Support MSC3026 busy presence ([\element-hq#8043](matrix-org/matrix-react-sdk#8043)).
* Show displayname in non-narrow thread summeries ([\element-hq#8036](matrix-org/matrix-react-sdk#8036)). Fixes element-hq#19646.
* Tweak search dialog based on new designs ([\element-hq#7980](matrix-org/matrix-react-sdk#7980)). Fixes element-hq#21285 and element-hq#21289.
* fallback to event text in location body when map unavailable ([\element-hq#7982](matrix-org/matrix-react-sdk#7982)). Fixes element-hq#20655.
* Send pin drop location share events ([\#7967](matrix-org/matrix-react-sdk#7967)).
* fix quicktime video thumbnailing ([\element-hq#8108](matrix-org/matrix-react-sdk#8108)). Fixes element-hq#21505.
* Fix scroll behaviour in space panel ([\element-hq#8111](matrix-org/matrix-react-sdk#8111)). Fixes element-hq#21467.
* Fix emoting with emoji or pills ([\element-hq#8105](matrix-org/matrix-react-sdk#8105)). Fixes element-hq#21497.
* Remove padding of InviteDialog & fix visual regression ([\element-hq#8076](matrix-org/matrix-react-sdk#8076)). Fixes element-hq#20631. Contributed by @luixxiul.
* Fixes mx_MLocationBody_markerBorder ([\element-hq#8069](matrix-org/matrix-react-sdk#8069)). Fixes element-hq#21444. Contributed by @luixxiul.
* Make margin and padding of mx_InviteDialog_other consistent ([\#8063](matrix-org/matrix-react-sdk#8063)). Fixes element-hq#20631. Contributed by @luixxiul.
* Fix freeze/crash when 1:1 calling ([\element-hq#8057](matrix-org/matrix-react-sdk#8057)). Fixes element-hq#21181.
* Don't assume that widget IDs are unique ([\#8052](matrix-org/matrix-react-sdk#8052)). Fixes element-hq#21399.
* Fix the header of Space landing page ([\element-hq#8048](matrix-org/matrix-react-sdk#8048)). Fixes element-hq#21402. Contributed by @luixxiul.
* Fix buttons alignment of Space list header ([\element-hq#8047](matrix-org/matrix-react-sdk#8047)). Fixes element-hq#21401. Contributed by @luixxiul.
* Fix null-guarding regression around reply_to_event dispatch ([\element-hq#8039](matrix-org/matrix-react-sdk#8039)).
* Fix clicking on copy link to thread wrongly opening thread ([\element-hq#8038](matrix-org/matrix-react-sdk#8038)). Fixes element-hq#20653.
* Fix regression around replying to search results ([\element-hq#8035](matrix-org/matrix-react-sdk#8035)). Fixes element-hq#21389.
* Share shared history keys in the background ([\element-hq#8031](matrix-org/matrix-react-sdk#8031)). Fixes element-hq#21192.
* Paginate responses to pinned polls ([\element-hq#8025](matrix-org/matrix-react-sdk#8025)). Fixes element-hq#21382.
* Fix incorrect usage of unstable variant of `is_falling_back` ([\element-hq#8016](matrix-org/matrix-react-sdk#8016)).
* Fix issues with ThreadSummary in msc-enabled mode ([\element-hq#8018](matrix-org/matrix-react-sdk#8018)). Fixes matrix-org/element-web-rageshakes#11401 and matrix-org/element-web-rageshakes#11400.
* Fix alignment of polls within threads ([\element-hq#8017](matrix-org/matrix-react-sdk#8017)). Fixes element-hq#21235.
* Fix issues with thread summaries being wrong or stale ([\element-hq#8015](matrix-org/matrix-react-sdk#8015)). Fixes element-hq#21363 and element-hq#21204.
* Fix button border color of LeaveSpaceDialog ([\element-hq#8010](matrix-org/matrix-react-sdk#8010)). Fixes element-hq#21365. Contributed by @luixxiul.
* Fix room list scroll jumps ([\element-hq#7991](matrix-org/matrix-react-sdk#7991)). Fixes element-hq#19322.
* Fix a variety of issues with HTML → Markdown conversion ([\element-hq#8004](matrix-org/matrix-react-sdk#8004)). Fixes element-hq#10648, element-hq#20718, element-hq#10722, element-hq#10389, element-hq#17610 element-hq#9984 and element-hq#20140.
* Wrap EventTile rather than its children in an error boundary ([\element-hq#7945](matrix-org/matrix-react-sdk#7945)).
* Normalized shortcut formatting for quote expansion control ([\element-hq#7995](matrix-org/matrix-react-sdk#7995)). Fixes element-hq#19685. Contributed by @Sinharitik589.
* Fix buttons and text layout on Security Key dialog ([\element-hq#7996](matrix-org/matrix-react-sdk#7996)). Fixes element-hq#21330. Contributed by @luixxiul.
* Fix formatting not being applied after links ([\element-hq#7990](matrix-org/matrix-react-sdk#7990)). Fixes element-hq#20091.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Location-Sharing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter X-Needs-Investigation Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fallback to event text in location body when map unavailable matrix-org/matrix-react-sdk
6 participants
@andybalaam @lnicola @dbkr @t3chguy @aaronraimist @SimonBrandner