Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there can be threads with only reactions #20849

Closed
HarHarLinks opened this issue Feb 1, 2022 · 2 comments
Closed

there can be threads with only reactions #20849

HarHarLinks opened this issue Feb 1, 2022 · 2 comments
Assignees
Labels
A-Reactions A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@HarHarLinks
Copy link
Contributor

HarHarLinks commented Feb 1, 2022

When the user clicks "Start a thread" but chooses not to type and send a response, instead they add a reaction to the root message, the reactions only show in the Thread panel, not in the main timeline.
Adding an emoji reaction to the root message also stops the latest message in the thread from showing up in the thread summary

Reactions added to root messages in the thread timeline should show in the main timeline. Emoji reactions to the root message should not disrupt the summary


Original Issue content:

Steps to reproduce

  1. write a message
  2. click start thread
  3. only send reactions to the root

Outcome

What did you expect?

it shouldn't be a thread before another message is sent

Alternative solution

I consider this more ugly, but if you decide that it should be a thread, then at least there should be a thread summary that shows the last reaction

What happened instead?

it is a thread

see also

#20848

Operating system

arch

Application version

Element Nightly version: 2022020101 Olm version: 3.2.8

How did you install the app?

aur

Homeserver

1.51

Will you send logs?

No

@HarHarLinks
Copy link
Contributor Author

Apparently this doesn't appear as a thread for the other person in my DM at all. Instead: #20850

@SimonBrandner SimonBrandner added A-Reactions A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Feb 2, 2022
@github-actions github-actions bot added the Z-Labs label Feb 2, 2022
@andybalaam andybalaam assigned andybalaam and unassigned andybalaam Feb 4, 2022
@germain-gg
Copy link
Contributor

This has been fixed as part of the worked carried out of associated events for polls

Screen.Recording.2022-02-22.at.15.32.53.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reactions A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Development

No branches or pull requests

4 participants