Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads from another room appear in thread panel #20850

Closed
HarHarLinks opened this issue Feb 1, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#7873
Closed

Threads from another room appear in thread panel #20850

HarHarLinks opened this issue Feb 1, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#7873
Assignees
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Cannot-Reproduce Z-Labs

Comments

@HarHarLinks
Copy link
Contributor

Steps to reproduce

not sure in particular, just use some threads in some rooms

Outcome

What did you expect?

image

What happened instead?

seeing threads from other rooms as well

Operating system

arch

Application version

Element Nightly version: 2022020101 Olm version: 3.2.8

How did you install the app?

aur

Homeserver

1.51

Will you send logs?

No

@SimonBrandner SimonBrandner added A-Threads S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 2, 2022
@github-actions github-actions bot added the Z-Labs label Feb 2, 2022
@dbkr dbkr added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Feb 2, 2022
@germain-gg
Copy link
Contributor

I've not really been able to reproduce that one.
The threads displayed in that list always seem to be scoped to the correct room for me. Regardless of whether I hit a homeserver that has the new sets of APIs or not.

Are there any more steps that lead you to encounter this issue?

@HarHarLinks
Copy link
Contributor Author

HarHarLinks commented Feb 3, 2022

I just opened a random DM, opened the threads panel. There are 5 Threads:

  1. is actually from this room
  2. is from another room (group, e2ee) that also includes the DM participant
  3. is from this room
  4. is from another DM (e2ee) that does not include the DM participant
  5. is from https://matrix.to/#/#element-community-testing:matrix.org where I just demonstrated another threads bug

Some other properties are also mixed, e.g. 2 contains fallbacks from thread unaware clients. There is one message I wrote where editing it failed and it shows the edit fallback with * instead.

4+5 have no participants other than me.

All threads have been created with either currently nightly or stable, mostly today but also earlier this week.

current Element Nightly version: 2022020301
Olm version: 3.2.8

Labs settings:
image
image

Do you want a rageshake?

@thegcat
Copy link

thegcat commented Feb 13, 2022

(technically I'm on Element Desktop 1.10.1 on macOS 12, but my understanding is it's the same code at this point)

I also see a thread from room B when looking at the thread panel of room A, although the panel is set to "all thread for the current room".

The thread panel in room A shows 4 threads, the 3rd from top being from room B. The panel is also missing older threads from room A, though I'm not sure wether this is intended or not. I also just went to room B to check what the threads panel is showing there, and it showed the thread view (not the thread list) for the thread that is erroneously shown in the thread list from room A.

I just cache-busted said Element Desktop a few days ago (might be yesterday?), so this should be a problem that is reproducible on a "fresh" client? Seeing I had the panel with the erroneous thread open in room B, maybe the steps would be "open room B", "open a single thread view in room B", "switch to room A", "open thread list in room A"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Cannot-Reproduce Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants