-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threads from another room appear in thread panel #20850
Comments
I've not really been able to reproduce that one. Are there any more steps that lead you to encounter this issue? |
I just opened a random DM, opened the threads panel. There are 5 Threads:
Some other properties are also mixed, e.g. 2 contains fallbacks from thread unaware clients. There is one message I wrote where editing it failed and it shows the edit fallback with 4+5 have no participants other than me. All threads have been created with either currently nightly or stable, mostly today but also earlier this week. current Element Nightly version: 2022020301 Do you want a rageshake? |
(technically I'm on Element Desktop 1.10.1 on macOS 12, but my understanding is it's the same code at this point) I also see a thread from room B when looking at the thread panel of room A, although the panel is set to "all thread for the current room". The thread panel in room A shows 4 threads, the 3rd from top being from room B. The panel is also missing older threads from room A, though I'm not sure wether this is intended or not. I also just went to room B to check what the threads panel is showing there, and it showed the thread view (not the thread list) for the thread that is erroneously shown in the thread list from room A. I just cache-busted said Element Desktop a few days ago (might be yesterday?), so this should be a problem that is reproducible on a "fresh" client? Seeing I had the panel with the erroneous thread open in room B, maybe the steps would be "open room B", "open a single thread view in room B", "switch to room A", "open thread list in room A"? |
Fixes element-hq/element-web#20850 Stores the room model in the state and update it when the roomId prop gets updated
Steps to reproduce
not sure in particular, just use some threads in some rooms
Outcome
What did you expect?
What happened instead?
seeing threads from other rooms as well
Operating system
arch
Application version
Element Nightly version: 2022020101 Olm version: 3.2.8
How did you install the app?
aur
Homeserver
1.51
Will you send logs?
No
The text was updated successfully, but these errors were encountered: