Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Face With Open Eyes And Hand Over Mouth" overflows the emoji picker #22126

Closed
robintown opened this issue May 10, 2022 · 7 comments · Fixed by matrix-org/matrix-react-sdk#10028
Labels
A-Emoji good first issue Good for newcomers Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect

Comments

@robintown
Copy link
Member

robintown commented May 10, 2022

Steps to reproduce

  1. Open the emoji picker
  2. Hover over "Face With Open Eyes And Hand Over Mouth"

Outcome

What did you expect?

The text should be ellipsized, or something

What happened instead?

overflow

Operating system

NixOS unstable

Browser information

Firefox 99.0.1

URL for webapp

develop.element.io

Application version

Element version: cdf95ab-react-c1579f765a8a-js-62d77231afd4 Olm version: 3.2.8

Homeserver

Synapse 1.58.0

Will you send logs?

No

@robintown robintown added T-Defect S-Tolerable Low/no impact on users A-Emoji O-Occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers labels May 10, 2022
@kittykat kittykat added the Help Wanted Extra attention is needed label May 11, 2022
@yaya-usman
Copy link
Contributor

@robintown how about this state? but i had to decrease the font-size a bit.

Capture1

@robintown
Copy link
Member Author

Rather than decreasing the font size (which would require design review), we should probably just remove the possibility of the text overflowing the container by giving it an appropriate overflow property. We may also want to limit the description to 1 line in CSS.

@yaya-usman
Copy link
Contributor

yaya-usman commented May 12, 2022

I decreased the fontsize a bit because no overflow property can fit the text well except the scroll property which is not ideal in my opinion. Also concerning the description text, it's too large or long to fit into one line, it's probably gonna break into two line. But if you want it to be ellipsized, i can do that but the user will not be able to read the full text as shown in the image below

Capture1

@robintown
Copy link
Member Author

That's probably fine, the shortcode for instance will become much shorter once our emoji sources actually have proper shortcode coverage for Emoji 14.

@SAGARGAUD01
Copy link

The issue is solved or not ?
assign me if issue is not solved yet.

@VaibhavAPatil
Copy link

I am interested in this Issue. Can I do Pull Request or you can assign this issue to Me.

@robintown
Copy link
Member Author

Thank you for your interest, but this issue is already resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment