Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar is blank in Element Call video rooms #23301

Closed
DoM1niC opened this issue Sep 16, 2022 · 4 comments · Fixed by matrix-org/matrix-react-sdk#9429
Closed

Avatar is blank in Element Call video rooms #23301

DoM1niC opened this issue Sep 16, 2022 · 4 comments · Fixed by matrix-org/matrix-react-sdk#9429
Assignees
Labels
A-Avatar A-Element-Call Group calls via Element Call O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs

Comments

@DoM1niC
Copy link

DoM1niC commented Sep 16, 2022

Steps to reproduce

  1. Set a Avatar
  2. Join a Element Call with Element Web

Outcome

grafik

Operating system

Any

Browser information

Desktop

URL for webapp

messenger.3dns.eu

Will you send logs?

No

@robintown robintown transferred this issue from element-hq/element-call Sep 17, 2022
@SimonBrandner SimonBrandner added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Avatar A-Element-Call Group calls via Element Call O-Occasional Affects or can be seen by some users regularly or most users rarely Z-Labs labels Sep 17, 2022
@robintown robintown changed the title blank Avatar Avatar is blank in Element Call video rooms Sep 21, 2022
@robintown
Copy link
Member

robintown commented Sep 23, 2022

This happens because the EC widget has no idea what the homeserver URL is, and so it spits out /_matrix/media/r0/thumbnail/example.org/xyz as the image src, with no protocol or domain. We need to thread the homeserver URL through EC into the js-sdk.

@toger5
Copy link
Contributor

toger5 commented Oct 10, 2022

But we would need the list of home servers for all participants right? (for me to download the profile picture of a participant from another home server would require to know their domain.
Can the home server domains be reliably obtained by the user id's? (they are available in the widget through the data from the accessible state events?)

@t3chguy
Copy link
Member

t3chguy commented Oct 10, 2022

Can the home server domains be reliably obtained by the user id's?

Yes, using the well-known lookup as specced https://spec.matrix.org/v1.4/client-server-api/#server-discovery

BUT I would advise against this as it'd leak your public IP address to servers other than your own.

@robintown
Copy link
Member

@toger5 You shouldn't need to know anything more than the user's own homeserver URL, since the media endpoint will automatically pull files in over federation if it's not yet on your own server

@robintown robintown self-assigned this Oct 18, 2022
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Oct 29, 2022
* Include a file-safe room name and ISO date in chat exports ([\matrix-org#9440](matrix-org#9440)). Fixes element-hq/element-web#21812 and element-hq/element-web#19724.
* Room call banner ([\matrix-org#9378](matrix-org#9378)). Fixes element-hq/element-web#23453. Contributed by @toger5.
* Device manager - spinners while devices are signing out ([\matrix-org#9433](matrix-org#9433)). Fixes element-hq/element-web#15865.
* Device manager - silence call ringers when local notifications are silenced ([\matrix-org#9420](matrix-org#9420)).
* Pass the current language to Element Call ([\matrix-org#9427](matrix-org#9427)).
* Hide screen-sharing button in Element Call on desktop ([\matrix-org#9423](matrix-org#9423)).
* Add reply support to WysiwygComposer ([\matrix-org#9422](matrix-org#9422)). Contributed by @florianduros.
* Disconnect other connected devices (of the same user) when joining an Element call ([\matrix-org#9379](matrix-org#9379)).
* Device manager - device tile main click target ([\matrix-org#9409](matrix-org#9409)).
* Add formatting buttons to the rich text editor ([\matrix-org#9410](matrix-org#9410)). Contributed by @florianduros.
* Device manager - current session context menu ([\matrix-org#9386](matrix-org#9386)).
* Remove piwik config fallback for privacy policy URL ([\matrix-org#9390](matrix-org#9390)).
* Add the first step to integrate the matrix wysiwyg composer ([\matrix-org#9374](matrix-org#9374)). Contributed by @florianduros.
* Device manager - UA parsing tweaks ([\matrix-org#9382](matrix-org#9382)).
* Device manager - remove client information events when disabling setting ([\matrix-org#9384](matrix-org#9384)).
* Add Element Call participant limit ([\matrix-org#9358](matrix-org#9358)).
* Add Element Call room settings ([\matrix-org#9347](matrix-org#9347)).
* Device manager - render extended device information ([\matrix-org#9360](matrix-org#9360)).
* New group call experience: Room header and PiP designs ([\matrix-org#9351](matrix-org#9351)).
* Pass language to Jitsi Widget ([\matrix-org#9346](matrix-org#9346)). Contributed by @Fox32.
* Add notifications and toasts for Element Call calls ([\matrix-org#9337](matrix-org#9337)).
* Device manager - device type icon ([\matrix-org#9355](matrix-org#9355)).
* Delete the remainder of groups ([\matrix-org#9357](matrix-org#9357)). Fixes element-hq/element-web#22770.
* Device manager - display client information in device details ([\matrix-org#9315](matrix-org#9315)).
* Send Content-Type: application/json header for integration manager /register API ([\matrix-org#9490](matrix-org#9490)). Fixes element-hq/element-web#23580.
* Device manager - put client/browser device metadata in correct section ([\matrix-org#9447](matrix-org#9447)).
* update the room unread notification counter when the server changes the value without any related read receipt ([\matrix-org#9438](matrix-org#9438)).
* Don't show call banners in video rooms ([\matrix-org#9441](matrix-org#9441)).
* Prevent useContextMenu isOpen from being true if the button ref goes away ([\matrix-org#9418](matrix-org#9418)). Fixes matrix-org/element-web-rageshakes#15637.
* Automatically focus the WYSIWYG composer when you enter a room ([\matrix-org#9412](matrix-org#9412)).
* Improve the tooltips on the call lobby join button ([\matrix-org#9428](matrix-org#9428)).
* Pass the homeserver's base URL to Element Call ([\matrix-org#9429](matrix-org#9429)). Fixes element-hq/element-web#23301.
* Better accommodate long room names in call toasts ([\matrix-org#9426](matrix-org#9426)).
* Hide virtual widgets from the room info panel ([\matrix-org#9424](matrix-org#9424)). Fixes element-hq/element-web#23494.
* Inhibit clicking on sender avatar in threads list ([\matrix-org#9417](matrix-org#9417)). Fixes element-hq/element-web#23482.
* Correct the dir parameter of MSC3715 ([\matrix-org#9391](matrix-org#9391)). Contributed by @dhenneke.
* Use a more correct subset of users in `/remakeolm` developer command ([\matrix-org#9402](matrix-org#9402)).
* use correct default for notification silencing ([\matrix-org#9388](matrix-org#9388)). Fixes element-hq/element-web#23456.
* Device manager - eagerly create `m.local_notification_settings` events ([\matrix-org#9353](matrix-org#9353)).
* Close incoming Element call toast when viewing the call lobby ([\matrix-org#9375](matrix-org#9375)).
* Always allow enabling sending read receipts ([\matrix-org#9367](matrix-org#9367)). Fixes element-hq/element-web#23433.
* Fixes (element-hq/element-web/issues/22609) where the white theme is not applied when `white -> dark -> white` sequence is done. ([\matrix-org#9320](matrix-org#9320)). Contributed by @florianduros.
* Fix applying programmatically set height for "top" room layout ([\matrix-org#9339](matrix-org#9339)). Contributed by @Fox32.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Avatar A-Element-Call Group calls via Element Call O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants