Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top menu item in context menus are highlighted #23582

Closed
anoadragon453 opened this issue Oct 24, 2022 · 4 comments · Fixed by matrix-org/matrix-react-sdk#9945
Closed

Top menu item in context menus are highlighted #23582

anoadragon453 opened this issue Oct 24, 2022 · 4 comments · Fixed by matrix-org/matrix-react-sdk#9945
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design X-Regression

Comments

@anoadragon453
Copy link
Member

Steps to reproduce

This seems to be a regression in a recent version of Element Web.

Screencast.from.10-24-2022.04.48.32.PM.webm
  1. Right click a message or room
  2. The top-most entry in the context menu's items will be pre-highlighted
  3. It shouldn't be as I'm not hovering over it

Also occurs in the menu that appears when clicking your user avatar:
image

Outcome

What did you expect?

For no items to be highlighted if my mouse isn't over the context menu.

What happened instead?

The top entry is always highlighted until I use tab to switch to another entry.

Operating system

Arch Linux

Application version

Element version: 2022102401, Olm version: 3.2.12

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

@t3chguy
Copy link
Member

t3chguy commented Oct 24, 2022

That'll be because the accessibility roving tab-index will be selecting it probably

@kerryarchibald
Copy link
Contributor

Possible it should use outline focus styling rather than extending the hover style
Screenshot 2022-10-24 at 18 43 50

@t3chguy
Copy link
Member

t3chguy commented Oct 24, 2022

image

Before the change ^

@kittykat kittykat added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Oct 27, 2022
@weeman1337 weeman1337 changed the title Top menu item in right-click context menus are highlighted Top menu item in context menus are highlighted Dec 28, 2022
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Feb 1, 2023
* Quotes for rte ([\matrix-org#9932](matrix-org#9932)). Contributed by @alunturner.
* Show the room name in the room header during calls ([\matrix-org#9942](matrix-org#9942)). Fixes element-hq/element-web#24268.
* Add code blocks to rich text editor ([\matrix-org#9921](matrix-org#9921)). Contributed by @alunturner.
* Add new style for inline code ([\matrix-org#9936](matrix-org#9936)). Contributed by @florianduros.
* Add disabled button state to rich text editor ([\matrix-org#9930](matrix-org#9930)). Contributed by @alunturner.
* Change the rageshake "app" for auto-rageshakes ([\matrix-org#9909](matrix-org#9909)).
* Device manager - tweak settings display ([\matrix-org#9905](matrix-org#9905)). Contributed by @kerryarchibald.
* Add list functionality to rich text editor ([\matrix-org#9871](matrix-org#9871)). Contributed by @alunturner.
* Fix RTE focus behaviour in threads ([\matrix-org#9969](matrix-org#9969)). Fixes element-hq/element-web#23755. Contributed by @florianduros.
* #22204 Issue: Centered File info in lightbox ([\matrix-org#9971](matrix-org#9971)). Fixes element-hq/element-web#22204. Contributed by @Spartan09.
* Fix seekbar position for zero length audio ([\matrix-org#9949](matrix-org#9949)). Fixes element-hq/element-web#24248.
* Allow thread panel to be closed after being opened from notification ([\matrix-org#9937](matrix-org#9937)). Fixes element-hq/element-web#23764 element-hq/element-web#23852 and element-hq/element-web#24213. Contributed by @justjanne.
* Only highlight focused menu item if focus is supposed to be visible ([\matrix-org#9945](matrix-org#9945)). Fixes element-hq/element-web#23582.
* Prevent call durations from breaking onto multiple lines ([\matrix-org#9944](matrix-org#9944)).
* Tweak call lobby buttons to more closely match designs ([\matrix-org#9943](matrix-org#9943)).
* Do not show a broadcast as live immediately after the recording has stopped ([\matrix-org#9947](matrix-org#9947)). Fixes element-hq/element-web#24233.
* Clear the RTE before sending a message ([\matrix-org#9948](matrix-org#9948)). Contributed by @florianduros.
* Fix {enter} press in RTE ([\matrix-org#9927](matrix-org#9927)). Contributed by @florianduros.
* Fix the problem that the password reset email has to be confirmed twice ([\matrix-org#9926](matrix-org#9926)). Fixes element-hq/element-web#24226.
* replace .at() with array.length-1 ([\matrix-org#9933](matrix-org#9933)). Fixes matrix-org/element-web-rageshakes#19281.
* Fix broken threads list timestamp layout ([\matrix-org#9922](matrix-org#9922)). Fixes element-hq/element-web#24243 and element-hq/element-web#24191. Contributed by @justjanne.
* Disable multiple messages when {enter} is pressed multiple times ([\matrix-org#9929](matrix-org#9929)). Fixes element-hq/element-web#24249. Contributed by @florianduros.
* Fix logout devices when resetting the password ([\matrix-org#9925](matrix-org#9925)). Fixes element-hq/element-web#24228.
* Fix: Poll replies overflow when not enough space ([\matrix-org#9924](matrix-org#9924)). Fixes element-hq/element-web#24227. Contributed by @kerryarchibald.
* State event updates are not forwarded to the widget from invitation room ([\matrix-org#9802](matrix-org#9802)). Contributed by @maheichyk.
* Fix error when viewing source of redacted events ([\matrix-org#9914](matrix-org#9914)). Fixes element-hq/element-web#24165. Contributed by @clarkf.
* Replace outdated css attribute ([\matrix-org#9912](matrix-org#9912)). Fixes element-hq/element-web#24218. Contributed by @justjanne.
* Clear isLogin theme override when user is no longer viewing login screens ([\matrix-org#9911](matrix-org#9911)). Fixes element-hq/element-web#23893.
* Fix reply action in message context menu notif & file panels ([\matrix-org#9895](matrix-org#9895)). Fixes element-hq/element-web#23970.
* Fix issue where thread dropdown would not show up correctly ([\matrix-org#9872](matrix-org#9872)). Fixes element-hq/element-web#24040. Contributed by @justjanne.
* Fix unexpected composer growing ([\matrix-org#9889](matrix-org#9889)). Contributed by @florianduros.
* Fix misaligned timestamps for thread roots which are emotes ([\matrix-org#9875](matrix-org#9875)). Fixes element-hq/element-web#23897. Contributed by @justjanne.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design X-Regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants