Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads are missing from the timeline #24036

Closed
MadLittleMods opened this issue Dec 16, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2996
Closed

Threads are missing from the timeline #24036

MadLittleMods opened this issue Dec 16, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2996
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Dec 16, 2022

Steps to reproduce

  1. As UserA, create a room
  2. Send 10x messages, start a thread on the 10th message add 2x thread replies
    • Repeat this 5 times
  3. Add some messages on the end for good measure
  4. As UserB, join the room
  5. Notice all of the threads are missing
  6. Click on the threads list and notice how all of the threads magically appear now

Outcome

What did you expect?

Threads are visible in the timeline from the beginning.

Why doesn't Element show the thread preview based on the bundled aggregation/relations of the message? But also clearly, Element paginated over where the thread replies should be anyway. What happened to them?

Message "40" event source
{
  "content": {
    "body": "40",
    "msgtype": "m.text",
    "org.matrix.msc1767.text": "40"
  },
  "origin_server_ts": 1671166588638,
  "room_id": "!jKOotgfiQODgEnlHkJ:matrix.org",
  "sender": "@erictroupetester:matrix.org",
  "type": "m.room.message",
  "unsigned": {
    "age": 571239,
    "m.relations": {
      "m.thread": {
        "latest_event": {
          "content": {
            "body": "40 thread reply2",
            "m.relates_to": {
              "event_id": "$Mhu-FIe1fF2mfdwgeISxzmMekf_zRybOvlfbhj2yDw4",
              "is_falling_back": true,
              "m.in_reply_to": {
                "event_id": "$sapwxdnkg_H5FWK7cWJIPqcWQ0zCc5QMPNyXBqkWvW0"
              },
              "rel_type": "m.thread"
            },
            "msgtype": "m.text",
            "org.matrix.msc1767.text": "40 thread reply2"
          },
          "origin_server_ts": 1671166598660,
          "room_id": "!jKOotgfiQODgEnlHkJ:matrix.org",
          "sender": "@erictroupetester:matrix.org",
          "type": "m.room.message",
          "unsigned": {
            "age": 561217
          },
          "event_id": "$FHtruJ4cdNW437XzkoHI9LxgSsY-_fmtjrpFmzf2nyc",
          "user_id": "@erictroupetester:matrix.org",
          "age": 561217
        },
        "count": 2,
        "current_user_participated": false
      }
    }
  },
  "event_id": "$Mhu-FIe1fF2mfdwgeISxzmMekf_zRybOvlfbhj2yDw4",
  "user_id": "@erictroupetester:matrix.org",
  "age": 571239
}

Additionally, threads should be shown regardless of how far away the thread reply was sent from the thread root. But this doesn't even apply to this case as the thread replies are sent immediately after the thread root.

What happened instead?

The threads are missing

chrome_2022-12-15_23-00-16.mp4

Operating system

Windows 10

Browser information

Chrome Version 108.0.5359.99

URL for webapp

https://develop.element.io/

Application version

Element version: a7124c9-react-b728b2743565-js-447319737a05 Olm version: 3.2.12

Tested with v1.11.15, v1.11.16, and latest develop.element.io where it's all reproducible

Homeserver

matrix.org

Will you send logs?

No

@t3chguy t3chguy added S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Release-Blocker O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 16, 2022
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jan 19, 2023
* Remove extensible events v1 field population on legacy events ([\matrix-org#3040](matrix-org#3040)).
* Improve hasUserReadEvent and getUserReadUpTo realibility with threads ([\matrix-org#3031](matrix-org#3031)). Fixes element-hq/element-web#24164.
* Remove video track when muting video ([\matrix-org#3028](matrix-org#3028)). Fixes element-hq/element-call#209.
* Make poll start event type available (PSG-962) ([\matrix-org#3034](matrix-org#3034)).
* Add alt event type matching in Relations model ([\matrix-org#3018](matrix-org#3018)).
* Remove usage of v1 Identity Server API ([\matrix-org#3003](matrix-org#3003)).
* Add `device_id` to `/account/whoami` types ([\matrix-org#3005](matrix-org#3005)).
* Implement MSC3912: Relation-based redactions ([\matrix-org#2954](matrix-org#2954)).
* Introduce a mechanism for using the rust-crypto-sdk ([\matrix-org#2969](matrix-org#2969)).
* Support MSC3391: Account data deletion ([\matrix-org#2967](matrix-org#2967)).
* Fix threaded cache receipt when event holds multiple receipts ([\matrix-org#3026](matrix-org#3026)).
* Fix false key requests after verifying new device ([\matrix-org#3029](matrix-org#3029)). Fixes element-hq/element-web#24167 and element-hq/element-web#23333.
* Avoid triggering decryption errors when decrypting redacted events ([\matrix-org#3004](matrix-org#3004)). Fixes element-hq/element-web#24084.
* bugfix: upload OTKs in sliding sync mode ([\matrix-org#3008](matrix-org#3008)).
* Apply edits discovered from sync after thread is initialised ([\matrix-org#3002](matrix-org#3002)). Fixes element-hq/element-web#23921.
* Sliding sync: Fix issue where no unsubs are sent when switching rooms ([\matrix-org#2991](matrix-org#2991)).
* Threads are missing from the timeline ([\matrix-org#2996](matrix-org#2996)). Fixes element-hq/element-web#24036.
* Close all streams when a call ends ([\matrix-org#2992](matrix-org#2992)). Fixes element-hq/element-call#742.
* Resume to-device message queue after resumed sync ([\matrix-org#2920](matrix-org#2920)). Fixes matrix-org/element-web-rageshakes#17170.
* Fix browser entrypoint ([\matrix-org#3051](matrix-org#3051)). Fixes matrix-org#3013.
* Fix failure to start in firefox private browser ([\matrix-org#3058](matrix-org#3058)). Fixes element-hq/element-web#24216.
* Correctly handle limited sync responses by resetting the thread timeline ([\matrix-org#3056](matrix-org#3056)). Fixes element-hq/element-web#23952.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants