Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuppressNotice push rule does not prevent the total notification count from increasing in encrypted rooms #24448

Closed
Half-Shot opened this issue Feb 6, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3130
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@Half-Shot
Copy link
Member

Steps to reproduce

  1. Create an encrypted room between two clients you control.
  2. Ensure the receiver has Messages sent by bot turned to the off position in the Notification settings.
  3. Ensure the reciever does NOT have the room focused.
  4. On the sending client, manually send a message with a msgtype of m.notice.
  5. On the receiving client, notice that the room notification count increases.

Outcome

What did you expect?

As with unencrypted rooms, the room notification count should not increase.

What happened instead?

The counter increases.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

Element version: 1.11.20 Olm version: 3.2.12

Homeserver

Synapse / half-shot.uk

Will you send logs?

No

@Half-Shot
Copy link
Member Author

Debugging notes

So far in my investigation, I can see that matrix-js-sdk correctly matches a PushRule against the encrypted event so getPushActionsForEvent will return a object with {"notify": false}

However, the subsequent logic block assumes that if the event does not highlight and the highlight count hasn't changed, no more adjustments need to be made on the client.

@dbkr dbkr added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely labels Feb 13, 2023
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Mar 15, 2023
* Add easy way to determine if the decryption failure is due to "DecryptionError: The sender has disabled encrypting to unverified devices." ([\matrix-org#3167](matrix-org#3167)). Contributed by @florianduros.
* Polls: expose end event id on poll model ([\matrix-org#3160](matrix-org#3160)). Contributed by @kerryarchibald.
* Polls: count undecryptable poll relations ([\matrix-org#3163](matrix-org#3163)). Contributed by @kerryarchibald.
* Fix spec compliance issue around encrypted `m.relates_to` ([\matrix-org#3178](matrix-org#3178)).
* Fix reactions in threads sometimes causing stuck notifications ([\matrix-org#3146](matrix-org#3146)). Fixes element-hq/element-web#24000. Contributed by @justjanne.
* Better type guard parseTopicContent ([\matrix-org#3165](matrix-org#3165)). Fixes matrix-org/element-web-rageshakes#20177 and matrix-org/element-web-rageshakes#20178.
* Fix a bug where events in encrypted rooms would sometimes erroneously increment the total unread counter after being processed locally. ([\matrix-org#3130](matrix-org#3130)). Fixes element-hq/element-web#24448. Contributed by @Half-Shot.
* Stop the ICE disconnected timer on call terminate ([\matrix-org#3147](matrix-org#3147)).
* Clear notifications when we can infer read status from receipts ([\matrix-org#3139](matrix-org#3139)). Fixes element-hq/element-web#23991.
* Messages sent out of order after one message fails ([\matrix-org#3131](matrix-org#3131)). Fixes element-hq/element-web#22885 and element-hq/element-web#18942. Contributed by @justjanne.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants