Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When connecting a new device, device verification does not start automatically #24490

Closed
giomfo opened this issue Feb 10, 2023 · 7 comments · Fixed by matrix-org/matrix-react-sdk#10467

Comments

@giomfo
Copy link
Member

giomfo commented Feb 10, 2023

Your use case

When a new session is detected the following dialog is displayed:
Screenshot 2023-02-10 at 18 56 37

What would you like to do?

Start the verify device process automatically instead of navigating to the devices list in the application settings.
When the dialog appears, the first click should kick-off the process.

Note: Don't mix up with the incoming verification dialog:
Screenshot 2023-02-10 at 18 50 26

Why would you like to do it?

How would you like to achieve it?

Have you considered any alternatives?

No response

Additional context

No response

@giomfo giomfo changed the title When connecting a new device, device verification does not start automatically anymore When connecting a new device, device verification does not start automatically Feb 10, 2023
@americanrefugee
Copy link

I think this is what you're asking for @giomfo ...

New log in:

New log in

Figma file

Verification requested:

Verification requested

Figma file

@americanrefugee
Copy link

@giomfo I also wanted to add some clarifications...

  • For New Log In: Clicking "No" will take the user to the Settings page showing them a list of their devices, where they can sign out from the unrecognized device. In this case, we should also recommend that they change their password.
  • For Verification Requested: This prompt is independent of the one for New Log In, in case that wasn't clear. The user would only see this if they initiated verification from their new device.

@pmaier1
Copy link

pmaier1 commented Feb 13, 2023

Just to make sure there's no misunderstanding:

  • The "new login" dialog is currently not meant to initiate the device verification. It's rather a security feature to notify users about new logins on their account. That's why it guides you to the device manager to review your connected devices. It could be extended to guide you to device verification if the user hits "Yes, it was me" in When connecting a new device, device verification does not start automatically #24490 (comment).
  • Usually the device verification process is initiated from the new device. Therefore I'm not sure which problem we're solving if we additionally allow starting it from the "new login" dialog.

What's the actual user story here?

@giomfo
Copy link
Member Author

giomfo commented Feb 16, 2023

Thanks @americanrefugee and @pmaier1, we agree with your suggestion. We will schedule the implementation of the suggested design.

The "new login" dialog is currently not meant to initiate the device verification. [..]. It could be extended to guide you to device verification if the user hits "Yes, it was me" in When connecting a new device, device verification does not start automatically #24490 (comment).

  • we think that we should not start the verification on "Yes, it was me" click.
  • Eventually we may add a new dialog on this click to explain why they should verify this new session, and suggest this verification (not sure we want to add this now)

@pmaier1
Copy link

pmaier1 commented Feb 16, 2023

we think that we should not start the verification on "Yes, it was me" click.

Agree 👍

Eventually we may add a new dialog on this click to explain why they should verify this new session, and suggest this verification (not sure we want to add this now)

Please take into account that the verification dialog will automatically appear once a user starts the verification on a new device. I'm wondering what it is that you will change here after all. Is it just the button labels then?

@giomfo
Copy link
Member Author

giomfo commented Feb 16, 2023

I'm wondering what it is that you will change here after all. Is it just the button labels then?

Yes, and the layout of the dialog

@weeman1337
Copy link
Contributor

Button labels are up to date. The new layout is still missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants