Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pill UI #24855

Closed
weeman1337 opened this issue Mar 17, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#10417
Closed

New pill UI #24855

weeman1337 opened this issue Mar 17, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#10417

Comments

@weeman1337
Copy link
Contributor

Your use case

What would you like to do?

Apply the new pill UI from here element-hq/element-meta#1030

It may not match 100 %, because the new UI breaks the text flow. The line height of lines with pills will increase. The result should be as close as possible to the new UI without breaking the text flow.

Have you considered any alternatives?

No response

Additional context

No response

@weeman1337

This comment was marked as outdated.

@giomfo
Copy link
Member

giomfo commented Mar 21, 2023

@weeman1337 I will list here some changes we will apply during this second step on permalinks rendering:

  • in case of a permalink to a message, the avatar is displayed at the beginning of the pill

image

image

  • in case of a permalink to a message in the same room, if we failed to retrieve the event or the user details, we display the link icon and the label "Message"

image

To reproduce this last case, you may send a permalink to a message sent by an ignored user, or a permalink to a message with a fake event id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants