Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Tweak pill UI #10417

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Tweak pill UI #10417

merged 3 commits into from
Mar 22, 2023

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Mar 21, 2023 •
edited
Loading

Changes:

  • Avatars should always be displayed on the left side
  • If a permalink target event in the same room cannot be loaded, the pill label will only be „Message“
Before After
image image

part of element-hq/element-meta#1030

closes element-hq/element-web#24855

PSF-1962

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 21, 2023
@weeman1337 weeman1337 marked this pull request as ready for review March 21, 2023 13:53
@weeman1337 weeman1337 requested a review from a team as a code owner March 21, 2023 13:53
@t3chguy t3chguy added the X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue label Mar 22, 2023
germain-gg
germain-gg approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me! Do you know how the component behaves when the text has to wrap over two lines?

@weeman1337
Copy link
Contributor Author

Looks sane to me! Do you know how the component behaves when the text has to wrap over two lines?

It will cut the text and add ellipsis

image

@weeman1337
Copy link
Contributor Author

Percy diff looks unrelated. Can you approve @t3chguy ?

Also added element-hq/element-web#24889 . It would make sense to write some e2e tests for the permalink pills.

@andybalaam
Copy link
Contributor

Percy diff looks unrelated. Can you approve @t3chguy ?

Also added vector-im/element-web#24889 . It would make sense to write some e2e tests for the permalink pills.

Approved.

@weeman1337 weeman1337 merged commit 3eb6a55 into develop Mar 22, 2023
@weeman1337 weeman1337 deleted the weeman1337/pill-ui branch March 22, 2023 12:27
This was referenced Apr 19, 2023
Open
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New pill UI
4 participants
@weeman1337 @andybalaam @germain-gg @t3chguy