Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Cypress test - should handle long room address and long room name on right-panel.spec.ts #25317

Closed
luixxiul opened this issue May 9, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#10835
Assignees
Labels

Comments

@luixxiul
Copy link

luixxiul commented May 9, 2023

Steps to reproduce

  1. Check https://cloud.cypress.io/projects/ppvnzg/runs/5dc8530c-98db-4a4a-aa4d-ab0c7dff8336/test-results/901b191b-dac6-4260-93d0-2de44d76ab7b

Outcome

What did you expect?

The test should run consistently.

What happened instead?

It sometimes fails due to the error below:

The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection.

  > Cannot read properties of null (reading 'isValid')

When Cypress detects uncaught errors originating from your application it will automatically fail the current test.

This behavior is configurable, and you can choose to turn this off by listening to the uncaught:exception event.

https://on.cypress.io/uncaught-exception-from-application

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@luixxiul
Copy link
Author

luixxiul commented May 9, 2023

Should checking its existence before clicking fix the issue, like cy.findByRole("button", { name: "Room info" }).should("exist").click();?

@richvdh
Copy link
Member

richvdh commented May 10, 2023

Introduced by matrix-org/matrix-react-sdk#10811, presumably?

@luixxiul
Copy link
Author

Since that PR added that test, I guess it should be so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants