Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Flaky Cypress test - should handle long room address and long room name on right-panel.spec.ts #10835

Merged
merged 3 commits into from
May 11, 2023
Merged

Flaky Cypress test - should handle long room address and long room name on right-panel.spec.ts #10835

merged 3 commits into from
May 11, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented May 9, 2023 •
edited by github-actions bot
Loading

Fixes element-hq/element-web#25317

Auto merge enabled

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 9, 2023
@kerryarchibald kerryarchibald marked this pull request as ready for review May 10, 2023 00:37
@kerryarchibald kerryarchibald requested a review from a team as a code owner May 10, 2023 00:37
@kerryarchibald kerryarchibald added this pull request to the merge queue May 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2023
richvdh
richvdh reviewed May 10, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some information on how or why this fixes the issue would be nice...

@kerryarchibald kerryarchibald added this pull request to the merge queue May 11, 2023
Merged via the queue into develop with commit 675756a May 11, 2023
@kerryarchibald kerryarchibald deleted the kerry/25317/flaky-right-panel branch May 11, 2023 03:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh left review comments

@weeman1337 weeman1337 weeman1337 approved these changes

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky Cypress test - should handle long room address and long room name on right-panel.spec.ts
3 participants
@kerryarchibald @richvdh @weeman1337