Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't accept the terms of service for the integration manager #25526

Closed
buffless-matt opened this issue Jun 7, 2023 · 3 comments · Fixed by matrix-org/matrix-js-sdk#3455
Closed

Can't accept the terms of service for the integration manager #25526

buffless-matt opened this issue Jun 7, 2023 · 3 comments · Fixed by matrix-org/matrix-js-sdk#3455
Assignees
@kerryarchibald
Labels
A-Integrations O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression X-Release-Blocker

Comments

@buffless-matt
Copy link

Steps to reproduce

  1. Open Element Desktop.
  2. Authenticate with a user that hasn't accepted the integration manager terms of service.
  3. Open a room.
  4. Click the "Room info" icon (top right).
  5. Click "Add widgets, bridges & bots".

Outcome

What did you expect?

The terms prompt to be rendered.

What happened instead?

image

Operating system

Ubuntu

Application version

Element version: 1.11.32 Olm version: 3.2.14

How did you install the app?

From https://element.io/download

Homeserver

matrix.org

Will you send logs?

No
@buffless-matt
Copy link
Author

Root cause:

@kerryarchibald kerryarchibald mentioned this issue Jun 7, 2023
Merged
3 tasks
@kittykat kittykat added S-Critical Prevents work, causes data loss and/or has no workaround A-Integrations O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jun 8, 2023
@andybalaam
Copy link
Member

Awesome bug report, thank you @buffless-matt

@andybalaam
Copy link
Member

Fixed in v1.11.33

su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Dec 13, 2023
@su-ex
Merge tag 'v26.0.1' into sc
255144e 
* Fix: handle `baseUrl` with trailing slash in `fetch.getUrl` ([\matrix-org#3455](matrix-org#3455)). Fixes element-hq/element-web#25526. Contributed by @kerryarchibald.
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Dec 13, 2023
@su-ex
Merge tag 'v1.11.33' into sc
72ddb82 
* Bump matrix-react-sdk to v3.73.1 for matrix-js-sdk v26.0.1 Fixes element-hq/element-web#25526.
su-ex added a commit to SchildiChat/element-web that referenced this issue Dec 13, 2023
@su-ex
Merge tag 'v1.11.33' into sc
ae50037 
* Bump matrix-react-sdk to v3.73.1 for matrix-js-sdk v26.0.1. Fixes element-hq#25526.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Dec 13, 2023
@su-ex
Merge tag 'v3.73.1' into sc
2e4d0bc 
* Bump matrix-js-sdk to v26.0.1. Fixes element-hq/element-web#25526
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Feb 22, 2024
@su-ex
Merge tag 'v26.1.0' into sc
10fe11f 
* Introduce a new `Crypto.Verifier` interface, and deprecate direct access to `VerificationBase`, `SAS` and `ReciprocateQRCode` ([\matrix-org#3414](matrix-org#3414)).
* Add `rust-crypto#isCrossSigningReady` implementation ([\matrix-org#3462](matrix-org#3462)). Contributed by @florianduros.
* OIDC: Validate `m.authentication` configuration ([\matrix-org#3419](matrix-org#3419)). Contributed by @kerryarchibald.
* ElementR: Add `CryptoApi.getCrossSigningStatus` ([\matrix-org#3452](matrix-org#3452)). Contributed by @florianduros.
* Extend stats summary with call device and user count based on room state ([\matrix-org#3424](matrix-org#3424)). Contributed by @toger5.
* Update MSC3912 implementation to use `with_rel_type` instead of `with_relations` ([\matrix-org#3420](matrix-org#3420)).
* Export thread-related types from SDK ([\matrix-org#3447](matrix-org#3447)). Contributed by @stas-demydiuk.
* Use correct /v3 prefix for /refresh ([\matrix-org#3016](matrix-org#3016)). Contributed by @davidisaaclee.
* Fix thread list being ordered based on all updates ([\matrix-org#3458](matrix-org#3458)). Fixes element-hq/element-web#25522.
* Fix: handle `baseUrl` with trailing slash in `fetch.getUrl` ([\matrix-org#3455](matrix-org#3455)). Fixes element-hq/element-web#25526. Contributed by @kerryarchibald.
* use cli.canSupport to determine intentional mentions support ([\matrix-org#3445](matrix-org#3445)). Fixes element-hq/element-web#25497. Contributed by @kerryarchibald.
* Make sliding sync linearize processing of sync requests ([\matrix-org#3442](matrix-org#3442)).
* Fix edge cases around 2nd order relations and threads ([\matrix-org#3437](matrix-org#3437)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kerryarchibald kerryarchibald

Labels
A-Integrations O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: handle baseUrl with trailing slash in fetch.getUrl matrix-org/matrix-js-sdk
6 participants
@kittykat @andybalaam @Johennes @t3chguy @kerryarchibald @buffless-matt