Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote indicator disappears on hover #25811

Closed
turt2live opened this issue Jul 16, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11273
Closed

Quote indicator disappears on hover #25811

turt2live opened this issue Jul 16, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11273
Assignees
@germain-gg
Labels
A-Appearance O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Send a message with a quote
  2. Hover over it

Outcome

What did you expect?

The quote indicator should always be visible

What happened instead?

Not hover:
image

Hover:
image

Operating system

Windows 11

Application version

Element Nightly version: 0.0.1-nightly.2023071401 Olm version: 3.2.14

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

No
@turt2live turt2live mentioned this issue Jul 16, 2023
Closed
@germain-gg germain-gg self-assigned this Jul 16, 2023
@germain-gg germain-gg added X-Regression S-Tolerable Low/no impact on users A-Appearance O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jul 16, 2023
germain-gg pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 17, 2023
Fix quote border for highlighted events
55faada 
Fixes element-hq/element-web#25811
@germain-gg germain-gg mentioned this issue Jul 17, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 17, 2023
Fix colour regressions (#11273)
5d4153f 
* Fix color contrast of notice events

Fixes element-hq/element-web#25808

* Restore alert color for highlighted events

Fixes element-hq/element-web#25788

* Fix quote border for highlighted events

Fixes element-hq/element-web#25811

* Fix media background mixing with event highlighted

Fixes element-hq/element-web#25812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Appearance O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix colour regressions matrix-org/matrix-react-sdk
2 participants
@germain-gg @turt2live