Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non highlight messages do not increase count #25881

Closed
germain-gg opened this issue Jul 31, 2023 · 5 comments · Fixed by matrix-org/matrix-js-sdk#3639
Closed

Non highlight messages do not increase count #25881

germain-gg opened this issue Jul 31, 2023 · 5 comments · Fixed by matrix-org/matrix-js-sdk#3639
Assignees
@t3chguy
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@germain-gg
Copy link
Contributor

germain-gg commented Jul 31, 2023 •
edited
Loading

Steps to reproduce

  1. Receive a message in an encrypted room

Outcome

What did you expect?

To have a notification count increase

What happened instead?

Nothing

I have the Notification Settings beta enabled.
The incriminated room has "Match default settings"

Only "highlights" caused a count increase

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

Yes
@germain-gg germain-gg added T-Defect X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely Z-Labs labels Jul 31, 2023
@t3chguy
Copy link
Member

t3chguy commented Jul 31, 2023

Sounds like a subset of #25794

@germain-gg
Copy link
Contributor Author

I think it's quite different, mentions work perfectly fine. I've been using the beta for a little while now and I only started noticing it with the last nightly update.

@daniellekirkwood
Copy link
Contributor

Same here - rooms that are marked "Default" are no longer incrementing the count but should be

@daniellekirkwood daniellekirkwood added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jul 31, 2023
@github-actions github-actions bot removed the Z-Labs label Jul 31, 2023
@weeman1337
Copy link
Contributor

weeman1337 commented Jul 31, 2023 •
edited
Loading

I did not join the new notifications settings beta and see the same problem. Logs sent.

@t3chguy t3chguy self-assigned this Jul 31, 2023
@t3chguy
Copy link
Member

t3chguy commented Jul 31, 2023

Regressed by matrix-org/matrix-js-sdk#3634

@t3chguy t3chguy mentioned this issue Jul 31, 2023
Merged
@t3chguy t3chguy mentioned this issue Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Ensure we don't overinflate the total notification count" matrix-org/matrix-js-sdk
4 participants
@germain-gg @t3chguy @weeman1337 @daniellekirkwood