Signing out a session does not show error if server returns an error

[weeman1337]

Steps to reproduce

1. Go to session manager
2. Click „sign out“ on a device

Outcome

What did you expect?

Device to be signed out

What happened instead?

Nothing in UI

Errors in console:

POST https://element.ems.host/_matrix/client/r0/delete_devices 404
Error deleting sessions M_UNRECOGNIZED: MatrixError: [404] Unrecognized request (https://element.ems.host/_matrix/client/r0/delete_devices)

The device I want to sign out is returned by the /devices request

Operating system

Ubuntu 22.04.3 LTS

Application version

Element Nightly version: 2023080901 Olm version: 3.2.14

How did you install the app?

https://packages.element.io/debian/

Homeserver

https://element.ems.host/

Will you send logs?

Yes

[weeman1337]

S-Critical because I may not be able to sign out a compromised device.

[weeman1337]

While this may also be a backend issue we should at least display some feedback about what happened. Currently there is no feedback at all.

[t3chguy]

https://spec.matrix.org/legacy/client_server/r0.6.1.html#post-matrix-client-r0-delete-devices - definitely a recognized request, not a critical client issue, but certainly a critical deployment/backend issue.

[t3chguy]

(not a regression on the client's PoV either as we didn't change anything)

[weeman1337]

Why is the request send to /_matrix/client/r0/delete_devices from the ancient spec and not to /_matrix/client/v3/delete_devices?

[t3chguy]

@weeman1337 because we support Matrix versions back all the way back to r0.6.1 - and older

[t3chguy]

matrix-org/matrix-js-sdk#3007 will be setting a minimum Matrix version of v1.1 which will allow us to start using the v3 of this API

[pmaier1]

Thanks for reporting. The issue is known and we're looking into it. It's likely related to the OIDC/MAS migration. Ref. matrix-org/matrix-authentication-service#1534

[daniellekirkwood]

@pmaier1, (and others) : Once you've fixed this, will there be work from the WAT needed to close out this issue?

[pmaier1]

@pmaier1, (and others) : Once you've fixed this, will there be work from the WAT needed to close out this issue?

This has already been fixed by changing matrix-org/matrix-spec-proposals#3824 to cover this use case and implementing it in Web. You can test it on any homeserver that has MAS deployed.