Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module API for adding extra icons into the room header #26028

Closed
Tracked by #25883
Johennes opened this issue Aug 22, 2023 · 3 comments
Closed
Tracked by #25883

Add module API for adding extra icons into the room header #26028

Johennes opened this issue Aug 22, 2023 · 3 comments
Labels
A-Timesheet-1 Log any time spent on this into the A-Timesheet-1 project O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement Z-Compound

Comments

@Johennes
Copy link
Contributor

Johennes commented Aug 22, 2023

Context

Screenshot 2023-10-05 at 11 20 07
  • We want to provide the ability to add extra icons to the room header.
  • The displayed icons can change based on which room is currently displayed
  • All icons are to be displayed on the left part of the existing ones to avoid unwanted layout shift

Requirements

Store

The store should probably expose the following attribute for every button

  • An SVG symbol
  • And most probably the component props of the <IconButton /> however it is probably not desirable to create a direct mapping

We might also want to provide a way to open a hyperlink and use an anchor rather than a button and an onClick callback

@Johennes Johennes changed the title Module customisation endpoint to add extra icons Add module API for adding extra icons into the room header Aug 22, 2023
@andybalaam andybalaam added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 23, 2023
@emmaburton1 emmaburton1 added the A-Timesheet-1 Log any time spent on this into the A-Timesheet-1 project label Sep 26, 2023
@emmaburton1
Copy link

@Johennes Drawing your attention to the A-Timesheet-1 label. 👀

@emmaburton1
Copy link

emmaburton1 commented Oct 24, 2023

@Johennes Do you have an ETA for when work will start on this?

Edit: Answered elsewhere, thanks.

@Johennes
Copy link
Contributor Author

We've clarified IRL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timesheet-1 Log any time spent on this into the A-Timesheet-1 project O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement Z-Compound
Projects
None yet
Development

No branches or pull requests

3 participants