Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding extra icons to the room header #22

Merged

Conversation

charlynguyen
Copy link
Contributor

@charlynguyen charlynguyen commented Oct 25, 2023

This PR allows to add extra icons to the room header.

Related issue: element-hq/element-web#26028
Blocks: matrix-org/matrix-react-sdk#11799

Screens

Legacy Room Header

legacy-room-header

New Room Header

new-room-header

Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
@charlynguyen charlynguyen marked this pull request as ready for review October 25, 2023 22:24
@charlynguyen charlynguyen requested a review from a team as a code owner October 25, 2023 22:24
@weeman1337 weeman1337 requested review from germain-gg and removed request for weeman1337 October 26, 2023 07:20
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM 👍

src/lifecycles/RoomViewLifecycle.ts Outdated Show resolved Hide resolved
Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@germain-gg germain-gg enabled auto-merge (squash) October 27, 2023 07:23
@germain-gg germain-gg merged commit 130bcd1 into matrix-org:main Oct 27, 2023
6 checks passed
@charlynguyen charlynguyen deleted the charlynguyen/room-header-extra-icons branch October 27, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants