Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar placeholders in timeline use the wrong font #26061

Closed
robintown opened this issue Aug 26, 2023 · 4 comments · Fixed by matrix-org/matrix-react-sdk#11483 or matrix-org/matrix-react-sdk#11593
Closed

Avatar placeholders in timeline use the wrong font #26061

robintown opened this issue Aug 26, 2023 · 4 comments · Fixed by matrix-org/matrix-react-sdk#11483 or matrix-org/matrix-react-sdk#11593
Assignees
@MidhunSureshR
Labels
A-Avatar A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. In the timeline, look at the avatar of someone who doesn't have a profile picture set

Outcome

What did you expect?

It should use the Inter font:

Screenshot 2023-08-26 at 17-56-05 Element 16 kaıkaı

What happened instead?

It uses my browser's default font, which happens to be Cantarell:

Screenshot 2023-08-26 at 17-55-13 Element 15 kaıkaı

Operating system

NixOS unstable

Browser information

Firefox 115.0.2

URL for webapp

develop.element.io

Application version

Element version: fcd8052-react-64f762d7b0f3-js-5788d9744b76 Olm version: 3.2.14

Homeserver

Not relevant

Will you send logs?

No
@robintown robintown added T-Defect X-Regression S-Tolerable Low/no impact on users A-Timeline A-Avatar O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 26, 2023
@germain-gg
Copy link
Contributor

Do you use a custom system font in your setting?

Looking at the current version of Element, using a custom system font does also override the font used to display the initials on avatars.

@germain-gg germain-gg self-assigned this Aug 29, 2023
@robintown
Copy link
Member Author

No, I am not using any custom fonts

@HarHarLinks
Copy link
Contributor

this seems related, in my room list, I get:
image
and in the timeline:
image

discussed earlier in https://matrix.to/#/!zzGPdcyFqxIOJEijoI:matrix.org/$6SB1-bFdRMYKBCIkryT13Is_fzPlapHnThRApjttnsw?via=matrix.org&via=element.io&via=envs.net

germain-gg pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 30, 2023
Fixes avatar placeholder font
03cce45 
Fixes element-hq/element-web#26061
@germain-gg germain-gg mentioned this issue Aug 30, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 30, 2023
Fixes read receipt avatar offset (#11483)
6aa86a8 
* Fixes read receipt avatar offset

Fixes element-hq/element-web#26059

* Fix avatar collapsing in thread list

Fixes element-hq/element-web#26064

* Make composer pills use new avatar design

Fixes element-hq/element-web#26067

* Update snapshots

* Update UserInfo snapshot

* Update HTMLExport snapshot

* Fixes avatar placeholder font

Fixes element-hq/element-web#26061
@MidhunSureshR
Copy link
Member

I can still reproduce this issue, so reopening

@MidhunSureshR MidhunSureshR reopened this Sep 8, 2023
@MidhunSureshR MidhunSureshR mentioned this issue Sep 8, 2023
Merged
3 tasks
@Johennes Johennes assigned MidhunSureshR and unassigned germain-gg Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MidhunSureshR MidhunSureshR

Labels
A-Avatar A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Milestone
No milestone
4 participants
@germain-gg @HarHarLinks @MidhunSureshR @robintown