Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Disabled] Flaky Playwright test: Threads > should be usable for a conversation #26452

Closed
richvdh opened this issue Oct 26, 2023 · 4 comments · Fixed by #28976
Closed

[Disabled] Flaky Playwright test: Threads > should be usable for a conversation #26452

richvdh opened this issue Oct 26, 2023 · 4 comments · Fixed by #28976
Labels
A-Developer-Experience O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Flaky-Test A test is raising false alarms Z-Flaky-Test-Disabled The flaking test has been disabled

Comments

@richvdh
Copy link
Member

richvdh commented Oct 26, 2023

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6642883792/job/18048683069#step:8:2216

  1) Threads
       should be usable for a conversation:
     TypeError: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection.

  > Cannot read properties of undefined (reading 'shouldAttemptDecryption')

When Cypress detects uncaught errors originating from your application it will automatically fail the current test.

This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event.

https://on.cypress.io/uncaught-exception-from-application
      at MatrixClient.decryptEventIfNeeded (http://localhost:8080/bundles/5c677ee9ac7c78c6c469/bundle.js:16628:15)
      at <unknown> (http://localhost:8080/bundles/5c677ee9ac7c78c6c469/element-web-app.js:39579:14)
      at Array.forEach (<anonymous>)
      at TimelinePanel_TimelinePanel.getEvents (http://localhost:8080/bundles/5c677ee9ac7c78c6c469/element-web-app.js:39577:64)
      at <unknown> (http://localhost:8080/bundles/5c677ee9ac7c78c6c469/element-web-app.js:38601:18)

Looks like TimelineWindow.getEvents returned an undefined value?

@richvdh richvdh added the Z-Flaky-Test A test is raising false alarms label Oct 26, 2023
@richvdh
Copy link
Member Author

richvdh commented Oct 26, 2023

Previously this test failed with a different error: #23438

@robintown robintown added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Developer-Experience O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 30, 2023
@dbkr
Copy link
Member

dbkr commented Oct 31, 2023

This has just flaked for me (kicking my js-sdk PR out of the merge queue) and accordingly has reached its two strikes.

Failure: https://github.com/matrix-org/matrix-js-sdk/actions/runs/6706755472/job/18223868253

dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 31, 2023
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 31, 2023
@richvdh richvdh changed the title Flaky Cypress test: Threads > should be usable for a conversation [Disabled] Flaky Cypress test: Threads > should be usable for a conversation Feb 15, 2024
@richvdh richvdh changed the title [Disabled] Flaky Cypress test: Threads > should be usable for a conversation [Disabled] Flaky Playwright test: Threads > should be usable for a conversation Feb 29, 2024
@github-actions github-actions bot added the Stale label Apr 24, 2024
Copy link

This flaky test issue has not been updated in 14 days. It is being closed as presumed resolved.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
@richvdh richvdh reopened this Apr 24, 2024
@github-actions github-actions bot added the Stale label May 17, 2024
Copy link

This flaky test issue has not been updated in 14 days. It is being closed as presumed resolved.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
@MidhunSureshR MidhunSureshR added the Z-Flaky-Test-Disabled The flaking test has been disabled label Jun 19, 2024
@MidhunSureshR MidhunSureshR reopened this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Developer-Experience O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Flaky-Test A test is raising false alarms Z-Flaky-Test-Disabled The flaking test has been disabled
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants