-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji should render when keyword is marked with colons #2838
Comments
Would a collapsed emoji keyboard (like on iOS/android) make sense? Should this be a separate issue? |
I personally would like to have better emoji support and even custom emoji. |
the beta rich-text-editor is already doing this. it just needs to be finished. see matrix-org/matrix-react-sdk#518. |
The rich text editor brings up the selector window, but it does not expand
fully typed keywords even when surrounded by colons. This issue is specific
to converting these to emoji, not simply filtering the selector (as it
currently operates).
…On Dec 30, 2016 10:47 AM, "Matthew Hodgson" ***@***.***> wrote:
the beta rich-text-editor is already doing this. it just needs to be
finished. see matrix-org/matrix-react-sdk#518
<matrix-org/matrix-react-sdk#518>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2838 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFZDRcK0581Y9naUvzmh1m5Bq-Yzx5qmks5rNUOagaJpZM4LWDhV>
.
|
That is by design, so it is up to you to choose whether or not you want them replaced. |
this is basically a dup of #2802. |
When a user enters an emoji keyword surrounded by colons, it should render as an emoji.
Examples:
:smiley:
should render as the smiley face:astonished:
should render as the astonished faceThe text was updated successfully, but these errors were encountered: