Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riot fails to remove backslashes if the resulting message is entirely plain text #2870

Closed
ghost opened this issue Jan 3, 2017 · 6 comments
Closed

Riot fails to remove backslashes if the resulting message is entirely plain text #2870

ghost opened this issue Jan 3, 2017 · 6 comments
Assignees
@kegsay
Labels
P2 T-Defect Z-Power-Users
Milestone
UX Fixes

Comments

@ghost
Copy link

ghost commented Jan 3, 2017 •
edited by ghost
Loading

Test vectors:
\*correct\* because of *other markdown* -> *correct* because of other markdown
\*incorrect\* -> \*incorrect\*

https://matrix.to/#/!XqBunHwQIXUiqCaoxq:matrix.org/$14834739331042207DLNXN:matrix.org
@kyrias
Copy link

kyrias commented Jan 3, 2017

I have a fix for this ready already, but it's blocked on matrix-org/matrix-react-sdk#575.

@ara4n
Copy link
Member

ara4n commented Jan 10, 2017

this is super-annoying. I just tried to past egrep "{PUT-O-(seq -s | 497 578|578)}" homeserver.log.5 into a mainly-IRC channel from Matrix, and the MD totally mangled it on the IRC side, and i couldn't escape it :(

@kyrias
Copy link

kyrias commented Jan 11, 2017

(Anyone feeling like Java or Obj-C development? ;p)

@ara4n ara4n added this to the UX Fixes milestone Jan 12, 2017
@ara4n
Copy link
Member

ara4n commented Jan 16, 2017

kegan has the con on switching riot-web to commonmark. we're not going to try to do it in sync with mobile. this can then land!

@kegsay kegsay mentioned this issue Jan 17, 2017
Merged
@kegsay
Copy link
Contributor

kegsay commented Jan 17, 2017

@kyrias : You said you had a fix for this already somewhere? Can has please? 🐱

kyrias added a commit to kyrias/matrix-react-sdk that referenced this issue Jan 17, 2017
@kyrias
Fix escaping markdown by rendering plaintext
893a5c9 
We still need to parse "plaintext" messages through the markdown
renderer so that escappes are rendered properly.

Fixes element-hq/element-web#2870.

Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
@kegsay kegsay mentioned this issue Jan 18, 2017
Merged
@kegsay
Copy link
Contributor

kegsay commented Jan 19, 2017

Annnd it's merged.

@kegsay kegsay closed this as completed Jan 19, 2017
@dbkr dbkr mentioned this issue Mar 28, 2017
Closed
@BobVul BobVul mentioned this issue Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kegsay kegsay

Labels
P2 T-Defect Z-Power-Users
Projects
None yet
Milestone
UX Fixes
Development

No branches or pull requests
3 participants
@ara4n @kyrias @kegsay