Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide menu for the desktop version #2962

Closed
schnuffle opened this issue Jan 16, 2017 · 2 comments
Closed

Hide menu for the desktop version #2962

schnuffle opened this issue Jan 16, 2017 · 2 comments

Comments

@schnuffle
Copy link

I played a bit with the riot desktop version, so I examined the menu on the top.
After some reasoning I come to the conclusion that the menu is only usefull for people developinng riot, normal user might more be confused by it.

I took a look at what can be easily changed and found a config parameter for the electron-BrowserWindow. I like it, pressing the "Alt" key toggles the menu, so it is still available.

Riot reads in a Preferences file so maybe it could be made a setting but I haven't had a look yet how that gets read in.

Here's the small patch in case somebody else has the same impression.

diff --git a/electron/src/electron-main.js b/electron/src/electron-main.js
index 675640a..1d15aab 100644
--- a/electron/src/electron-main.js
+++ b/electron/src/electron-main.js
@@ -164,6 +164,7 @@ electron.app.on('ready', () => {
 
     mainWindow = new electron.BrowserWindow({
         icon: icon_path,
+        autoHideMenuBar: true,
         width: 1024, height: 768,
         show: false,
     });
dbkr added a commit that referenced this issue Jan 18, 2017
From #2962

This allows all the shortcuts to still work, and the menu bar can
be un-hidden with the alt key.
@dbkr
Copy link
Member

dbkr commented Jan 18, 2017

Seems like a good compromise: PRed as #2975

@dbkr dbkr closed this as completed Jan 18, 2017
Half-Shot pushed a commit to Half-Shot/riot-web that referenced this issue Feb 9, 2017
From element-hq#2962

This allows all the shortcuts to still work, and the menu bar can
be un-hidden with the alt key.
@Pulfer
Copy link

Pulfer commented Jul 28, 2017

Unfortunately, using just Alt for menu is quite bad idea because it's common to switch input layouts using Alt+Shift. So every time people switch input layout the focus jumps from chat window to menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants