Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress the country+msisdn picker down to a single line #3895

Closed
lampholder opened this issue May 11, 2017 · 3 comments
Closed

Compress the country+msisdn picker down to a single line #3895

lampholder opened this issue May 11, 2017 · 3 comments

Comments

@lampholder
Copy link
Member

lampholder commented May 11, 2017

image

Points to note:

  • flags are actually square
  • country names have country codes after them to both:
    • reinforce that we're doing this for the phone number
    • allow the user to search by country code as well as country name
  • the country picker and the phone number field should both be similarly styled, so that it's obvious that they are both there to be interacted with/completed
  • +447700900000 is a reasonable placeholder because it is a drama range number
    • we might rethink this in future, but it's probably fine for now
@lampholder
Copy link
Member Author

lampholder commented May 11, 2017

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented May 17, 2017

Searching by country code does work but it doesn't strip the initial "+" if you happen to enter one. This breaks the search which assumes you haven't put a "+".

IRL @lampholder and I discussed that the dropdown can be much smaller that 50% but in practice this is a parameter that can be altered with minimal CSS anyway (once the above design is implemented). I mocked what this would like with devtools:
2017-05-17-113343_323x158_scrot
2017-05-17-113335_319x53_scrot

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented May 17, 2017

Next up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants