Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If inviting a user fails, user is shown a cryptic 'Failure to create room' error. #4062

Open
ara4n opened this issue May 28, 2017 · 10 comments
Labels
A-Error-Message A-Invite O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented May 28, 2017

I was testing ILAG on my local HS, which is not federated. It tried to invite riot-bot which failed with a 502 (not unreasonably), bubbling up a "Failure to create room" error. However, it then ditched me and didn't let me complete the flow to actually fill in the 'start chat' or 'create room' dialogs.

@lukebarnard1
Copy link
Contributor

This is expected, the only situation in which you should expect your intention before being a PWLU to be carried forward is when joining

@ara4n
Copy link
Member Author

ara4n commented May 30, 2017

it's still a very cryptic error though...

@lukebarnard1
Copy link
Contributor

Agreed, but this is quite orthogonal to ILAG and could be improved for invites in general.

@lampholder
Copy link
Member

Can we categorise this as "Failed invites should give better feedback than 'failure to create room' error", or something similar?

@lampholder lampholder added the X-Needs-Info This issue is blocked awaiting information from the reporter label May 30, 2017
@lampholder lampholder changed the title ILAG: If inviting riot-bot fails, start chat & create room buttons fail entirely If inviting riot-bot fails, user is shown a cryptic 'Failure to create room' error. Jun 1, 2017
@lampholder
Copy link
Member

Modifying the title, classifying as a bug and booting out of ILAG.

@lampholder lampholder added T-Defect P2 ui/ux and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Jun 1, 2017
@lampholder lampholder modified the milestone: minor Jun 1, 2017
@lampholder lampholder added the S-Minor Impairs non-critical functionality or suitable workarounds exist label Jun 1, 2017
@lampholder
Copy link
Member

P2 minor because (if I understand this correctly) this will only affect people who:

  • use a riot instance they don't host (and hence can't reconfigure the welcomeUserId setting in config.json)
  • to connect to a home server that can't federate with matrix.org

@ara4n
Copy link
Member Author

ara4n commented Jun 1, 2017 via email

@aaronraimist
Copy link
Collaborator

aaronraimist commented Oct 27, 2018

Error message looks like this

screen shot 2018-10-26 at 8 18 50 pm

You also still get an empty room even though the error message is failure to create room...

@abeluck
Copy link
Contributor

abeluck commented Feb 13, 2019

It is an awful experience for people who are running riot on a new non-fed HS though.
So true :(

This is still present in the redesign branch fwiw.

Edit: And in some ways it is worse in the redesign, after registering, the app hangs with a gray screen and static spinner for upwards of a minute or so, before throwing the error message. Most of my test users just refreshed the page, other thought it was broken.

@jryans jryans removed the Z-UI/UX label Mar 9, 2021
@t3chguy
Copy link
Member

t3chguy commented Jun 29, 2023

You also still get an empty room even though the error message is failure to create room...

That's matrix-org/synapse#8625 / matrix-org/synapse#8895

@t3chguy t3chguy removed the P2 label Aug 14, 2023
@t3chguy t3chguy added A-Invite A-Error-Message O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Error-Message A-Invite O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

7 participants