Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neighbouring code blocks appear as one #4535

Closed
lukebarnard1 opened this issue Jul 7, 2017 · 2 comments · Fixed by #4639
Closed

Neighbouring code blocks appear as one #4535

lukebarnard1 opened this issue Jul 7, 2017 · 2 comments · Fixed by #4639

Comments

@lukebarnard1
Copy link
Contributor

Instead of the selected range
@lukebarnard1 lukebarnard1 changed the title Clicking the "Quote" button seems to toggle the format for the last block Clicking the "Quote" or "Code-block" button seems to toggle the format for the last block Jul 7, 2017
@lukebarnard1
Copy link
Contributor Author

lukebarnard1 commented Jul 13, 2017 •
edited
Loading

Interestingly, the buttons behave differently to the default keyboard bindings, i.e. ctrl+j behaves differently to clicking the </> button. That's because the keyboard bindings are for inline formatting, i.e. not blocks.

@lukebarnard1
Copy link
Contributor Author

Also, it really does toggle the block you're in currently, it's just not obvious when you're in a block. So perhaps we should make it more obvious. For quotes is very obvious:

2017-07-13-182757_169x102_scrot

but for code blocks, it's not at all obvious:

2017-07-13-182810_201x108_scrot

@lukebarnard1 lukebarnard1 changed the title Clicking the "Quote" or "Code-block" button seems to toggle the format for the last block Neighbouring code blocks appear as one Jul 13, 2017
lukebarnard1 pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 13, 2017
Add code-block to the list of blocks where hitting return will split-…
219c00b 
…block

Hitting return in a code-block will now split the block into two code blocks. (Holding shift will still insert a soft newline into the current block).

We still need to make it a bit more obvious that consecutive code-blocks
are not contiguous - element-hq/element-web#4535
This was referenced Jul 13, 2017
Merged
Closed
@lukebarnard1 lukebarnard1 mentioned this issue Jul 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply CSS to <pre> tags to distinguish them from each other element-hq/element-web
1 participant
@lukebarnard1