Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The login button can have text overflowing out of the box in some locales and platforms #4804

Closed
Porkepix opened this issue Aug 16, 2017 · 4 comments
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Tolerable Low/no impact on users T-Defect

Comments

@Porkepix
Copy link
Contributor

Description

The login button can have text overflowing out of the box in some locales and platforms

Steps to reproduce

Describe how what happens differs from what you expected.

The box should be sized to contain the text.

Screenshot of the home

Version information

  • Platform: web

For the web app:

  • Browser: Firefox stable and nightly, Chrome.
  • OS: macOS
  • URL: riot.im/develop / riot.im/app

Additional informations:

Problem visible on both Firefox and Chrome on macOS, but not on Linux nor Windows.
It seems to be related to the font and its style (Linux may have the requested font missing too).
Text seems to be bold on macOS compared to other platforms.
I think it's important to check other locales for both the sign in and log in buttons as many locales can have longer texts than French.

@lampholder lampholder added T-Defect S-Tolerable Low/no impact on users easy P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Aug 17, 2017
@lampholder
Copy link
Member

Ideally these buttons would:

  • expand to fit the text content
  • wrap over two lines if both buttons can't fit on the same line

@turt2live
Copy link
Member

Duplicate of #4713

@t3chguy
Copy link
Member

t3chguy commented Aug 17, 2017

Thanks @turt2live
Closed other in favour of this one as it has @lampholder's master plan on it

@lukebarnard1
Copy link
Contributor

We might be able to get away with just using CSS, similarly to #4776

lukebarnard1 added a commit that referenced this issue Aug 31, 2017
Fix overflowing login/register buttons on some languages issue #4804
@dbkr dbkr closed this as completed in 1dfa836 Sep 6, 2017
dduran1967 pushed a commit to wiresafe/riot-web that referenced this issue Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

5 participants