Last word of wide character (Chinese/Japanese/Korean) isn't sent

[eunchan]

Description

If user types CJK sentence and press enter to send the text, last word won't be transmitted to the server.

Steps to reproduce

• Change to any CJK input method
• Type any sentence with a space between words.
• Press 'Enter' key while writing CJK word (period or space makes word complete so it will transmit the word)

Version information

• Platform: web (in-browser) or desktop both

For the web app:

• Browser: Chrome, Safari tested
• OS: macOS
• URL: riot.im/develop / riot.im/app / somewhere else? If a private server, what version of riot-web?

For the desktop app:

• OS: macOS
• Version: 0.12.7

[lampholder]

I haven't been able to reproduce this yet - I tried the pinyin - simplified input on macos and Microsoft Pinyin on windows and had a similar experience on both:

Pressing enter will kill the character selector and leave the roman characters in the composer, but it doesn't send anything without pressing enter again (and then it sends the mostly-completed Chinese sentence with just the last syllable un-transliterated).

I guess this problem is at least partially dependent on the input method being used - can you advise which one were you using when you experienced this problem?

[eunchan]

Thanks for the reply. I've tried macOS default korean input method and also other 3rd party input method. Both shows same. As you see on the screenshot, I've tried put the full sentence but it was only sent without last word. I've seen the similar issue on other Electron app (VSCode) but that time, the only last character was not sent not the whole last word.

[eunchan]

Maybe this GIF might useful.

[turt2live]

@eunchan are you still seeing this on recent Riot versions (0.17 and higher)?

[eunchan]

My organization no longer uses riot due to below issue. I didn’t test it after that. On Oct 31, 2018, at 4:07 PM, Travis Ralston <notifications@github.com> wrote: @eunchan <https://github.com/eunchan> are you still seeing this on recent Riot versions (0.17 and higher)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5495 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABIzbkH_9CoRjttE5H2vnuYyzyzSdmGTks5uqi0xgaJpZM4QO_Oo>.

[aaronraimist]

@turt2live Unfortunately there appears to be a pretty significant upstream bug in Slate that is worse than this issue.

Wrong:

Wrong:

Correct:

[aaronraimist]

@turt2live I assume someone is going to write a bunch of tests for all of these input bugs?

[turt2live]

@turt2live I assume someone is going to write a bunch of tests for all of these input bugs?

First step is figuring out what all the root causes are, then determining if they are upstream issues (like this one), then fixing, then maybe tests. It's incredibly difficult to write tests for the thousands of different ways to type a message though.

[turt2live]

Closing in favour of #7665 to track the upstream issue.