Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links opening in desktop app frame #8226

Closed
yanlinaung30 opened this issue Jan 23, 2019 · 3 comments
Closed

Links opening in desktop app frame #8226

yanlinaung30 opened this issue Jan 23, 2019 · 3 comments
Assignees
@dbkr
Labels
A-Electron T-Defect X-Regression

Comments

@yanlinaung30
Copy link

Description

URL is opening in RIOT and cannot return to homepage.

Steps to reproduce

  • I clicked a url on pop up menu in Riot.
  • It is opening in Riot and cannot return to home screen
  • There is no button to click.

Describe how what happens differs from what you expected.

Log: sent/not sent?

image

Version information

  • Platform: desktop

For the web app:

  • Browser: Chrome, Safari, Firefox? which version?
  • OS: Windows, macOS, Ubuntu, Arch Linux, etc?
  • URL: riot.im/develop / riot.im/app / somewhere else? If a private server, what version of riot-web?

For the desktop app:

  • OS: Windows
  • Version: 10
@turt2live
Copy link
Member

I clicked a url on pop up menu in Riot.

Was this a link in a message or somewhere else?

@yanlinaung30
Copy link
Author

yanlinaung30 commented Jan 23, 2019 •
edited
Loading

@turt2live
Warning message when I tried to reset my password.
It is resolved by

  1. when I restarted my Windows.
  2. when I closed riot (including from tray icon) & re-opened it.

image

@dbkr dbkr self-assigned this Jan 23, 2019
@dbkr dbkr changed the title Web Page is opeing in RIOT Links opening in desktop app frame Jan 23, 2019
@dbkr
Copy link
Member

dbkr commented Jan 23, 2019

Thanks for the bug report.

Issues here are twofold:

  1. We have a couple of links like this in the app which should have a target="_blank" on them, but don't (they'll navigate away from riot in the browser too)
  2. v0.17.9 enables sandbox mode in electron, and this bug: will-navigate event not fired when in sandbox mode electron/electron#8841

dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 24, 2019
@dbkr
Add target="_blank" to links that don't have it
4bcb9f1 
This is now more of a problem in the Electron app because of
electron/electron#8841 but is still
annoying in the webapp if you're taken away from your chat client.

Exception is the SSO link, as commented (issue filed at
element-hq/element-web#8247).

Fixes element-hq/element-web#8226
@dbkr dbkr mentioned this issue Jan 24, 2019
Merged
@dbkr dbkr closed this as completed Jan 25, 2019
@uhoreg uhoreg mentioned this issue Jan 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
A-Electron T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbkr @turt2live @yanlinaung30